Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible costmodel params #4284

Merged
merged 9 commits into from
May 8, 2024
Merged

Flexible costmodel params #4284

merged 9 commits into from
May 8, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Apr 19, 2024

Description

Fixes in this PR:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/flexible-costmodel-params branch 2 times, most recently from 9c0353f to bd0c660 Compare May 6, 2024 22:59
@lehins lehins marked this pull request as ready for review May 7, 2024 15:12
Copy link
Contributor

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far all I've seen is this typo

@lehins lehins force-pushed the lehins/flexible-costmodel-params branch from 25904f5 to 3e472d5 Compare May 7, 2024 21:50
Copy link
Contributor

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I think I understand the changes well enough.

I've made a minor suggestion for improving the wording of a comment, but feel free to ignore this if you don't want to delay merging.

@lehins lehins force-pushed the lehins/flexible-costmodel-params branch from 7b6721c to f9324de Compare May 7, 2024 22:45
@lehins lehins enabled auto-merge May 7, 2024 22:45
@lehins lehins merged commit dbb9f4e into master May 8, 2024
125 checks passed
@lehins lehins deleted the lehins/flexible-costmodel-params branch May 8, 2024 00:52
rooooooooob added a commit to dcSpark/cardano-multiplatform-lib that referenced this pull request Jun 17, 2024
Due to changes here: IntersectMBO/cardano-ledger#4284
Clarification here: IntersectMBO/cardano-ledger#4383

Allows non-Plutus languages according to the spec and changes to an
indexable map type.
rooooooooob added a commit to dcSpark/cardano-multiplatform-lib that referenced this pull request Jun 18, 2024
Due to changes here: IntersectMBO/cardano-ledger#4284
Clarification here: IntersectMBO/cardano-ledger#4383

Allows non-Plutus languages according to the spec and changes to an
indexable map type.
rooooooooob added a commit to dcSpark/cardano-multiplatform-lib that referenced this pull request Jul 23, 2024
Due to changes here: IntersectMBO/cardano-ledger#4284
Clarification here: IntersectMBO/cardano-ledger#4383

Allows non-Plutus languages according to the spec and changes to an
indexable map type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problematic cost model serialization
4 participants