-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Network for ProposalProcedure and TreasuryWithdrawal #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/validate-networkids
branch
from
August 17, 2023 14:28
e779167
to
f1e97b2
Compare
aniketd
commented
Aug 17, 2023
lehins
requested changes
Aug 17, 2023
teodanciu
reviewed
Aug 17, 2023
aniketd
force-pushed
the
aniketd/validate-networkids
branch
from
August 17, 2023 15:45
f1e97b2
to
eb6ebb9
Compare
aniketd
force-pushed
the
aniketd/validate-networkids
branch
from
August 17, 2023 15:53
eb6ebb9
to
012a52b
Compare
lehins
requested changes
Aug 17, 2023
aniketd
force-pushed
the
aniketd/validate-networkids
branch
from
August 17, 2023 18:23
7170677
to
b96c4ea
Compare
aniketd
force-pushed
the
aniketd/validate-networkids
branch
2 times, most recently
from
August 18, 2023 13:40
9807791
to
a792415
Compare
lehins
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you
for ProposalProcedure and TreasuryWithdrawals in GOV
lehins
force-pushed
the
aniketd/validate-networkids
branch
from
August 21, 2023 10:28
b19de1b
to
bc8967c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3603
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)