Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Network for ProposalProcedure and TreasuryWithdrawal #3659

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Aug 17, 2023

Description

Resolves #3603

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/validate-networkids branch from f1e97b2 to eb6ebb9 Compare August 17, 2023 15:45
@aniketd aniketd requested a review from lehins August 17, 2023 15:52
@aniketd aniketd force-pushed the aniketd/validate-networkids branch from eb6ebb9 to 012a52b Compare August 17, 2023 15:53
@aniketd aniketd force-pushed the aniketd/validate-networkids branch from 7170677 to b96c4ea Compare August 17, 2023 18:23
@aniketd aniketd requested a review from lehins August 17, 2023 18:25
@aniketd aniketd force-pushed the aniketd/validate-networkids branch 2 times, most recently from 9807791 to a792415 Compare August 18, 2023 13:40
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Enact.hs Outdated Show resolved Hide resolved
@lehins lehins force-pushed the aniketd/validate-networkids branch from b19de1b to bc8967c Compare August 21, 2023 10:28
@lehins lehins enabled auto-merge (squash) August 21, 2023 10:29
@lehins lehins merged commit 4c4f0f9 into master Aug 21, 2023
11 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/validate-networkids branch August 21, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate NetworkIds
4 participants