Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1678: epoch_stake missing entries #1796

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

1678: epoch_stake missing entries #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13838d6
1678: epoch_stake missing entries
Cmdv Jul 30, 2024
0242576
stake slicing with updated tests
Cmdv Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions cardano-chain-gen/test/Test/Cardano/Db/Mock/Config.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ module Test.Cardano.Db.Mock.Config (
withDBSyncEnv,
withFullConfig,
withFullConfigAndDropDB,
withFullConfigLogsDropDB,
withFullConfigAndLogs,
withCustomConfigAndLogsAndDropDB,
withCustomConfig,
Expand Down Expand Up @@ -354,6 +355,26 @@ withFullConfigAndDropDB =
initCommandLineArgs
Nothing

withFullConfigLogsDropDB ::
-- | config filepath
FilePath ->
-- | test label
FilePath ->
(Interpreter -> ServerHandle IO CardanoBlock -> DBSyncEnv -> IO a) ->
IOManager ->
[(Text, Text)] ->
IO a
withFullConfigLogsDropDB =
withFullConfig'
( WithConfigArgs
{ hasFingerprint = True
, shouldLog = True
, shouldDropDB = True
}
)
initCommandLineArgs
Nothing

withFullConfigAndLogs ::
-- | config filepath
FilePath ->
Expand Down
177 changes: 90 additions & 87 deletions cardano-chain-gen/test/Test/Cardano/Db/Mock/Unit/Alonzo/Stake.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{-# LANGUAGE NumericUnderscores #-}

module Test.Cardano.Db.Mock.Unit.Alonzo.Stake (
-- stake addresses
registrationTx,
Expand All @@ -24,7 +26,7 @@ import qualified Cardano.Mock.Forging.Tx.Alonzo as Alonzo
import Cardano.Mock.Forging.Tx.Alonzo.Scenarios (delegateAndSendBlocks)
import Cardano.Mock.Forging.Types (StakeIndex (..), UTxOIndex (..))
import Control.Concurrent.Class.MonadSTM.Strict (MonadSTM (atomically))
import Control.Monad (forM_, replicateM_, void)
import Control.Monad (forM_, void)
import Data.Text (Text)
import Ouroboros.Network.Block (blockSlot)
import Test.Cardano.Db.Mock.Config (alonzoConfigDir, startDBSync, withFullConfig, withFullConfigAndDropDB)
Expand All @@ -33,7 +35,6 @@ import Test.Cardano.Db.Mock.UnifiedApi (
fillUntilNextEpoch,
forgeAndSubmitBlocks,
forgeNextFindLeaderAndSubmit,
forgeNextSkipSlotsFindLeaderAndSubmit,
getAlonzoLedgerState,
withAlonzoFindLeaderAndSubmit,
withAlonzoFindLeaderAndSubmitTx,
Expand Down Expand Up @@ -215,126 +216,128 @@ stakeDistGenesis :: IOManager -> [(Text, Text)] -> Assertion
stakeDistGenesis =
withFullConfigAndDropDB alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
startDBSync dbSync
a <- fillUntilNextEpoch interpreter mockServer
assertBlockNoBackoff dbSync (fromIntegral $ length a)
-- There are 5 delegations in genesis
assertEpochStake dbSync 5
blks <- fillUntilNextEpoch interpreter mockServer
assertBlockNoBackoff dbSync (fromIntegral $ length blks)
-- There are 10 delegations in genesis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment correct or is the old comment wrong about genesi?

Copy link
Contributor Author

@Cmdv Cmdv Aug 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be removed. I think in the previous implementation, by the time the assertEpochStake was called the epoch 2 wouldn't have been inserted. This is why I changed the tests to check each epoch 1 + 2 separately

assertEpochStakeEpoch dbSync 1 5
assertEpochStakeEpoch dbSync 2 5
where
testLabel = "stakeDistGenesis-alonzo"

delegations2000 :: IOManager -> [(Text, Text)] -> Assertion
delegations2000 =
withFullConfig alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
withFullConfigAndDropDB alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
startDBSync dbSync
a <- delegateAndSendBlocks 1995 interpreter
forM_ a $ atomically . addBlock mockServer
b <- fillUntilNextEpoch interpreter mockServer
c <- forgeAndSubmitBlocks interpreter mockServer 10

assertBlockNoBackoff dbSync (fromIntegral $ length a + length b + length c)
-- There are exactly 2000 entries on the second epoch, 5 from genesis and 1995 manually added
blks <- delegateAndSendBlocks 1995 interpreter
forM_ blks (atomically . addBlock mockServer)
-- Fill the rest of the epoch
epoch <- fillUntilNextEpoch interpreter mockServer
-- Wait for them to sync
assertBlockNoBackoff dbSync (length blks + length epoch)
assertEpochStakeEpoch dbSync 1 5
-- Add some more blocks
blks' <- forgeAndSubmitBlocks interpreter mockServer 10
-- Wait for it to sync
assertBlockNoBackoff dbSync (length blks + length epoch + length blks')
assertEpochStakeEpoch dbSync 2 2000

-- Forge another block
void $ forgeNextFindLeaderAndSubmit interpreter mockServer []
assertBlockNoBackoff dbSync (fromIntegral $ length a + length b + length c + 1)
-- Wait for it to sync
assertBlockNoBackoff dbSync (length blks + length epoch + length blks' + 1)
-- There are still 2000 entries
assertEpochStakeEpoch dbSync 2 2000
where
testLabel = "delegations2000-alonzo"

delegations2001 :: IOManager -> [(Text, Text)] -> Assertion
delegations2001 =
withFullConfig alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
withFullConfigAndDropDB alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
startDBSync dbSync
a <- delegateAndSendBlocks 1996 interpreter
forM_ a $ atomically . addBlock mockServer
b <- fillUntilNextEpoch interpreter mockServer
c <- forgeAndSubmitBlocks interpreter mockServer 9

assertBlockNoBackoff dbSync (fromIntegral $ length a + length b + length c)
assertEpochStakeEpoch dbSync 2 0
-- We want exactly 2001 delegations, 5 from genesis and 1996 manually added
blks <- delegateAndSendBlocks 1996 interpreter
forM_ blks (atomically . addBlock mockServer)
-- Fill the rest of the epoch
epoch <- fillUntilNextEpoch interpreter mockServer
-- Add some more blocks
blks' <- forgeAndSubmitBlocks interpreter mockServer 9
-- Wait for it to sync
assertBlockNoBackoff dbSync (length blks + length epoch + length blks')
assertEpochStakeEpoch dbSync 1 5
-- The next 2000 entries is inserted on the next block
void $ forgeNextFindLeaderAndSubmit interpreter mockServer []
assertBlockNoBackoff dbSync (fromIntegral $ length a + length b + length c + 1)
assertEpochStakeEpoch dbSync 2 2000
-- The remaining entry is inserted on the next block.
assertBlockNoBackoff dbSync (length blks + length epoch + length blks' + 1)
assertEpochStakeEpoch dbSync 2 2001
-- The remaining entry is inserted on the next block
void $ forgeNextFindLeaderAndSubmit interpreter mockServer []
assertBlockNoBackoff dbSync (fromIntegral $ length a + length b + length c + 2)
assertBlockNoBackoff dbSync (length blks + length epoch + length blks' + 2)
assertEpochStakeEpoch dbSync 2 2001
where
testLabel = "delegations2001-alonzo"

delegations8000 :: IOManager -> [(Text, Text)] -> Assertion
delegations8000 =
withFullConfig alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
withFullConfigAndDropDB alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
startDBSync dbSync
a <- delegateAndSendBlocks 7995 interpreter
forM_ a $ atomically . addBlock mockServer
b <- fillEpochs interpreter mockServer 2
c <- forgeAndSubmitBlocks interpreter mockServer 10

assertBlockNoBackoff dbSync (fromIntegral $ length a + length b + length c)
assertEpochStakeEpoch dbSync 3 2000

void $ forgeNextFindLeaderAndSubmit interpreter mockServer []
assertEpochStakeEpoch dbSync 3 4000

void $ forgeNextFindLeaderAndSubmit interpreter mockServer []
assertEpochStakeEpoch dbSync 3 6000

void $ forgeNextFindLeaderAndSubmit interpreter mockServer []
assertEpochStakeEpoch dbSync 3 8000

void $ forgeNextFindLeaderAndSubmit interpreter mockServer []
assertEpochStakeEpoch dbSync 3 8000
-- We want exactly 8000 delegations, 5 from genesis and 7995 manually added
blks <- delegateAndSendBlocks 7995 interpreter
forM_ blks (atomically . addBlock mockServer)
-- Fill the rest of the epoch
epoch <- fillEpochs interpreter mockServer 2
-- Add some more blocks
blks' <- forgeAndSubmitBlocks interpreter mockServer 10
-- Wait for it to sync
assertBlockNoBackoff dbSync (length blks + length epoch + length blks')
assertEpochStakeEpoch dbSync 1 5
assertEpochStakeEpoch dbSync 2 8000
where
testLabel = "delegations8000-alonzo"

delegationsMany :: IOManager -> [(Text, Text)] -> Assertion
delegationsMany =
withFullConfig alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
withFullConfigAndDropDB alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
startDBSync dbSync
a <- delegateAndSendBlocks 40000 interpreter
forM_ a $ atomically . addBlock mockServer
b <- fillEpochs interpreter mockServer 4
c <- forgeAndSubmitBlocks interpreter mockServer 10

-- too long. We cannot use default delays
assertBlockNoBackoffTimes (repeat 10) dbSync (fromIntegral $ length a + length b + length c)
-- The slice size here is
-- 1 + div (delegationsLen * 5) expectedBlocks = 2001
-- instead of 2000, because there are many delegations
assertEpochStakeEpoch dbSync 7 2001

void $ forgeNextFindLeaderAndSubmit interpreter mockServer []
assertEpochStakeEpoch dbSync 7 4002

void $ forgeNextFindLeaderAndSubmit interpreter mockServer []
assertEpochStakeEpoch dbSync 7 6003
-- Forge many delegations
blks <- delegateAndSendBlocks 40_000 interpreter
forM_ blks (atomically . addBlock mockServer)
-- Fill some epochs
epochs <- fillEpochs interpreter mockServer 4
-- Add some more blocks
blks' <- forgeAndSubmitBlocks interpreter mockServer 10
-- We can't use default delays because this takes too long
assertBlockNoBackoffTimes
(repeat 10)
dbSync
(length blks + length epochs + length blks')
assertEpochStakeEpoch dbSync 6 40_005
assertEpochStakeEpoch dbSync 7 40_005
where
testLabel = "delegationsMany-alonzo"

delegationsManyNotDense :: IOManager -> [(Text, Text)] -> Assertion
delegationsManyNotDense =
withFullConfig alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
withFullConfigAndDropDB alonzoConfigDir testLabel $ \interpreter mockServer dbSync -> do
startDBSync dbSync
a <- delegateAndSendBlocks 40000 interpreter
forM_ a $ atomically . addBlock mockServer
b <- fillEpochs interpreter mockServer 4
c <- forgeAndSubmitBlocks interpreter mockServer 10

-- too long. We cannot use default delays
assertBlockNoBackoffTimes (repeat 10) dbSync (fromIntegral $ length a + length b + length c)
-- The slice size here is
-- 1 + div (delegationsLen * 5) expectedBlocks = 2001
-- instead of 2000, because there are many delegations
assertEpochStakeEpoch dbSync 7 2001

-- Blocks come on average every 5 slots. If we skip 15 slots before each block,
-- we are expected to get only 1/4 of the expected blocks. The adjusted slices
-- should still be long enough to cover everything.
replicateM_ 40 $
forgeNextSkipSlotsFindLeaderAndSubmit interpreter mockServer 15 []

-- Even if the chain is sparse, all distributions are inserted.
assertEpochStakeEpoch dbSync 7 40005
-- Forge many delegations
blks <- delegateAndSendBlocks 40_000 interpreter
forM_ blks (atomically . addBlock mockServer)
-- Fill some epochs
epochs <- fillEpochs interpreter mockServer 4
-- Add some more blocks
blks' <- forgeAndSubmitBlocks interpreter mockServer 10
-- We can't use default delays because this takes too long
assertBlockNoBackoffTimes
(repeat 10)
dbSync
(length blks + length epochs + length blks')
-- check the stake distribution for each epoch
assertEpochStakeEpoch dbSync 1 5
assertEpochStakeEpoch dbSync 2 12_505
assertEpochStakeEpoch dbSync 3 40_005
assertEpochStakeEpoch dbSync 4 40_005
assertEpochStakeEpoch dbSync 5 40_005
assertEpochStakeEpoch dbSync 6 40_005
assertEpochStakeEpoch dbSync 7 40_005
-- check the sum of stake distribution for all epochs
assertEpochStake dbSync 212_535
where
testLabel = "delegationsManyNotDense-alonzo"
Loading
Loading