-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Benchmarks #1058
base: master
Are you sure you want to change the base?
Benchmarks #1058
Conversation
98155ad
to
fce760d
Compare
fce760d
to
223e2a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two problems with this:
- We should probably avoid referencing people's personal GH accounts and instead move this to the
input-output-hk
account. - The
cabal.project
file does not contain a--sha256: ....
line for criterion which messes up the Nix build system. This hash can be generated by thenar
command in the repo https://github.com/input-output-hk/nix-archive/
Also, have you submitted a PR to upstream criterion
?
I should have marked this as WIP.
My patch may be good enough for what we want, but not good enough to pr criterion. It simply prints a list of measurements for each benchmark like this
The list has one meassurement per iteration, but there is no report created with all the benchmarks together. I'm not sure if it's worth improving the final report of benchmarks, or if we even want to have these benchmark merged or executed on ci. It's just a tool I used to easily test optimizations. |
29a1ce5
to
fbb69be
Compare
fbb69be
to
df44bc9
Compare
These benchmarks use a custom criterion, since the official releases don't allow users to determine the number of executions.
Can be executed with
The -T flag enables more measurements from the runtime, mostly gc time