Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log stats #1423

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Log stats #1423

wants to merge 5 commits into from

Conversation

AllentDan
Copy link
Collaborator

Open http://xxxx:23333/metrics/ to view the metrics.

@lvhan028 lvhan028 added the enhancement New feature or request label Apr 12, 2024
@zhulinJulia24
Copy link
Collaborator

感觉gpu和cpu是不是不用放里面,可以自己起一个nvidia的端口就能获得metrics,如 docker run -d --gpus all --rm -p 9400:9400 nvcr.io/nvidia/k8s/dcgm-exporter:3.1.7-3.1.4-ubuntu20.04

@zhulinJulia24
Copy link
Collaborator

能不能添加tokens相关性能指标?

@nathan-az
Copy link

Can we add first token time as well, so the difference between scheduling time and first token time can be used to estimate prefill time?

Here is vLLM's source as a reference

@@ -123,6 +123,10 @@ def add_parser_api_server():
type=str,
default='',
help='Qos policy config path')
parser.add_argument('--log-stats',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use --metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants