Introduce Filler derive macro for FillExt
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Idealy we don't place the trait in the macro crate. I think bifrost has good example of this for |
|
@oxkitsune I understand you want to avoid macros, I'll leave it up to you whether you want to include it or not, you can throw it out if you do not want it. |
oxkitsune
requested changes
Jul 26, 2023
jkbkaiser
commented
Jul 30, 2023
jkbkaiser
commented
Jul 30, 2023
oxkitsune
reviewed
Jul 30, 2023
|
@oxkitsune do we want to merge this? |
oxkitsune
reviewed
Aug 16, 2023
oxkitsune
changed the title
Filler derive macro for FillExt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know where to place the
FillExt<T>trait. Made it because I was playing around with macros, do not know if it has actual use.