Skip to content

Introduce JointArray::{map, zip} #133

Introduce JointArray::{map, zip}

Introduce JointArray::{map, zip} #133

Triggered via pull request August 15, 2023 16:07
Status Failure
Total duration 35s
Artifacts

rust.yml

on: pull_request
cicd  /  Cargo fmt
7s
cicd / Cargo fmt
cicd  /  Cargo clippy
20s
cicd / Cargo clippy
cicd  /  Cargo test
16s
cicd / Cargo test
cicd  /  Cargo build & test
22s
cicd / Cargo build & test
Fit to window
Zoom out
Zoom in

Annotations

7 errors and 20 warnings
method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter`: nidhogg/src/types.rs#L525
error: method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter` --> nidhogg/src/types.rs:525:5 | 525 | / pub fn from_iter<I>(mut iter: I) -> JointArray<T> 526 | | where 527 | | I: std::iter::Iterator<Item = T>, 528 | | { ... | 555 | | } 556 | | } | |_____^ | = help: consider implementing the trait `std::iter::FromIterator` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait = note: `-D clippy::should-implement-trait` implied by `-D warnings`
this expression creates a reference which is immediately dereferenced by the compiler: nidhogg/src/types.rs#L521
error: this expression creates a reference which is immediately dereferenced by the compiler --> nidhogg/src/types.rs:521:33 | 521 | JointArrayIterator::new(&self) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings`
the following explicit lifetimes could be elided: 'a: nidhogg/src/types.rs#L520
error: the following explicit lifetimes could be elided: 'a --> nidhogg/src/types.rs:520:5 | 520 | pub fn iter<'a>(&'a self) -> JointArrayIterator<'a, T> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-D clippy::needless-lifetimes` implied by `-D warnings` help: elide the lifetimes | 520 - pub fn iter<'a>(&'a self) -> JointArrayIterator<'a, T> { 520 + pub fn iter(&self) -> JointArrayIterator<'_, T> { |
method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter`: nidhogg/src/types.rs#L525
error: method `from_iter` can be confused for the standard trait method `std::iter::FromIterator::from_iter` --> nidhogg/src/types.rs:525:5 | 525 | / pub fn from_iter<I>(mut iter: I) -> JointArray<T> 526 | | where 527 | | I: std::iter::Iterator<Item = T>, 528 | | { ... | 555 | | } 556 | | } | |_____^ | = help: consider implementing the trait `std::iter::FromIterator` or choosing a less ambiguous method name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait = note: `-D clippy::should-implement-trait` implied by `-D warnings`
this expression creates a reference which is immediately dereferenced by the compiler: nidhogg/src/types.rs#L521
error: this expression creates a reference which is immediately dereferenced by the compiler --> nidhogg/src/types.rs:521:33 | 521 | JointArrayIterator::new(&self) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings`
the following explicit lifetimes could be elided: 'a: nidhogg/src/types.rs#L520
error: the following explicit lifetimes could be elided: 'a --> nidhogg/src/types.rs:520:5 | 520 | pub fn iter<'a>(&'a self) -> JointArrayIterator<'a, T> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-D clippy::needless-lifetimes` implied by `-D warnings` help: elide the lifetimes | 520 - pub fn iter<'a>(&'a self) -> JointArrayIterator<'a, T> { 520 + pub fn iter(&self) -> JointArrayIterator<'_, T> { |
cicd / Cargo clippy
Clippy had exited with the 101 exit code
cicd / Cargo fmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
cicd / Cargo fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
cicd / Cargo test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo build & test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
cicd / Cargo build & test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo build & test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo build & test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo build & test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
cicd / Cargo clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
cicd / Cargo clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/