Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added upstream OffsetsMask classes #2210

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added upstream OffsetsMask classes #2210

wants to merge 3 commits into from

Conversation

MattBDev
Copy link
Contributor

@MattBDev MattBDev commented May 5, 2023

Overview

Fixes one of the API incompatibilities we have with upstream by adding these new masks to FAWE.

Description

Adds two new masks to FAWE from upstream and ports a few FAWE changes into them.

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • Not Applicable: New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@MattBDev MattBDev requested a review from a team as a code owner May 5, 2023 02:06
@MattBDev
Copy link
Contributor Author

The checks seem to have failed but the code does compile and works. Not sure what is the cause of the failure to resolve dependencies and the CodeQL issue. I don’t even touch dependencies in this PR.

*/
@Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it forRemoval as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a question for @me4502 to answer. Hopefully, she can clarify for us.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely, generally deprecations are for removal in the next major version

there’s not much point having two classes that do the same thing here

Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants