Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Residence integration #2135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

NotMyFault
Copy link
Member

This PR is a follow-up to #2081:

Residence uses a non-standardized approach to build and distribute binaries, incompatible with the industry standard.
There have been community efforts on Residence's end to maven-ize the project, see https://github.com/Zrips/Residence/issues/42. Given there's been no progress in the past 6 years, I see no reason why we should continue maintaining our integration relying on our artifact, if the maintainer shows lack of motivation to move the community effort forward.

As shown by telemetry data, the impact of removal is surveyable. To be fair, I wouldn't take the 2% affected as gospel truth because our integration works if Fawe and Residence are both installed, which does not imply that everyone using Fawe and Residence alongside necessarily use Fawe's Residence features.
Nevertheless, I'll add an entry to the upcoming changelog to communicate this change and the reasoning.

@NotMyFault NotMyFault added the Breaking changes This PR causes a breaking change label Mar 7, 2023
@NotMyFault NotMyFault requested a review from a team as a code owner March 7, 2023 12:59
@dordsor21
Copy link
Member

Tbh unless it becomes a work-required feature, there's no need to remove residence support. If wherever we're pulling it in as a dependency has a compatible version with the latest residence releases then it's all good imo

@OneLiteFeather
Copy link
Member

About which Residence we talk? I found a fork on spigot that seemed active https://github.com/Zrips/Residence
You can find it on the same page the original came from.

@dordsor21
Copy link
Member

The issue is not how active it is, it's that it's to using any sort of build tooling, has no maven repository provided, etc. I suggest only removing residence at such a time the current integration no longer works, unless residence decides to become a useable open source project

@github-actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes This PR causes a breaking change unresolved-merge-conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants