Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added urdf & mesh files for D405 model #2953

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

Arun-Prasad-V
Copy link
Contributor

@Arun-Prasad-V Arun-Prasad-V commented Dec 22, 2023

Tracked on RSDSO-18600

Related issue: #2589

</geometry>
</collision>
<inertial>
<!-- The following are not reliable values, and should not be used for modeling -->
Copy link
Contributor Author

@Arun-Prasad-V Arun-Prasad-V Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section hasn't been updated. It has unreliable values.
In fact, all the previous URDF's of D415, D455, D435 models also have same unreliable values.

<!-- The following values model the aluminum peripherial case for the
d405 camera, with the camera joint represented by the actual
peripherial camera tripod mount -->
<xacro:property name="d405_cam_width" value="0.042"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curios , this is generated automatically some how or you set this values according to the STL file manually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values are set manually based on the dimensions mentioned in the datasheet.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Dec 24, 2023

Can you attach a visualization of the output?
*Closed and reopened by mistake :)

@Nir-Az Nir-Az closed this Dec 24, 2023
@Nir-Az Nir-Az reopened this Dec 24, 2023
@Arun-Prasad-V
Copy link
Contributor Author

FYR...

d405_urdf.webm.mp4

@Nir-Az
Copy link
Collaborator

Nir-Az commented Dec 26, 2023

Please verify if we can expose the optical lens as discussed

@Arun-Prasad-V
Copy link
Contributor Author

Please verify if we can expose the optical lens as discussed

The STEP file itself doesn't have the details of lens, so couldn't generate the mesh file with lens exposed.

@Arun-Prasad-V Arun-Prasad-V marked this pull request as ready for review December 26, 2023 14:40
@Nir-Az Nir-Az merged commit d7b029f into IntelRealSense:ros2-development Dec 26, 2023
12 checks passed
@Arun-Prasad-V Arun-Prasad-V deleted the d405_urdf branch January 31, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants