Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add live tests #2834

Closed

Conversation

PrasRsRos
Copy link
Contributor

Add template for live test using D455 camera that supports changing of parameters dynamically

if profile[0] == 'Color':
print("Testing :"+ profile[0] + " " + profile[1] + " " + profile[2])
if "BGRA8" == profile[2]:
print("Skipping " +profile[2])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added support for these type of formats in our node.
Still in review.. maybe when we merge my PR you will remove this "skipping"

@SamerKhshiboun
Copy link
Collaborator

Hi @PrasRsRos

I reviewed your PR, and it looks good.
Do you prefer to wait with this PR till we merge my PR (#2840) ?
After merging my PR, most of skipping tests should work in your side, and I think you should unskip these tests then.
If you want to handle these fixes of skips in another PR, let me know.
Meanwhile, I'm waiting for review on my PR.

return True
if "RGBA8" == format:
return True
if "Y10BPACK" == format:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on which camera model do you see this format ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in D415:

  • Infrared 1: 1920x1080 @ 30Hz Y10BPACK

@PrasRsRos
Copy link
Contributor Author

Imu test fails when trying to change enable_accel & enable_gyro dynamically.

@SamerKhshiboun
Copy link
Collaborator

Imu test fails when trying to change enable_accel & enable_gyro dynamically.

on specific model ? or on all cameras ?

@PrasRsRos
Copy link
Contributor Author

Imu test fails when trying to change enable_accel & enable_gyro dynamically.

on specific model ? or on all cameras ?

I could test only on D455. However, it could be an issue with my understanding also. So a review of the code helps before checking the code.

@PrasRsRos
Copy link
Contributor Author

New pull request: #2865

@PrasRsRos PrasRsRos closed this Aug 30, 2023
@PrasRsRos PrasRsRos deleted the add_live_tests branch August 30, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants