-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add live tests #2834
Add live tests #2834
Conversation
Modified Readme to reflect the changes in running pytest. This was happened due to the fixes made to fix the failures in prerelease
…enumerate-devices
…se-ros into add_live_tests
if profile[0] == 'Color': | ||
print("Testing :"+ profile[0] + " " + profile[1] + " " + profile[2]) | ||
if "BGRA8" == profile[2]: | ||
print("Skipping " +profile[2]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added support for these type of formats in our node.
Still in review.. maybe when we merge my PR you will remove this "skipping"
… with expected data
Hi @PrasRsRos I reviewed your PR, and it looks good. |
return True | ||
if "RGBA8" == format: | ||
return True | ||
if "Y10BPACK" == format: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on which camera model do you see this format ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in D415:
- Infrared 1: 1920x1080 @ 30Hz Y10BPACK
Imu test fails when trying to change enable_accel & enable_gyro dynamically. |
on specific model ? or on all cameras ? |
I could test only on D455. However, it could be an issue with my understanding also. So a review of the code helps before checking the code. |
New pull request: #2865 |
- add RGBD to development
- Add namespace launch argument
… with expected data
…se-ros into add_live_tests
Add template for live test using D455 camera that supports changing of parameters dynamically