Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove versioneer, organize dpnp monkey patch #1464

Merged
merged 3 commits into from
May 24, 2024
Merged

Remove versioneer, organize dpnp monkey patch #1464

merged 3 commits into from
May 24, 2024

Conversation

ZzEeKkAa
Copy link
Collaborator

@ZzEeKkAa ZzEeKkAa commented May 23, 2024 •
edited
Loading

Moves out dpnp user functions monkey patching to the designed patch folder. Updates _versioner.py on the build time so it is statically set and does not trigger any subprocesses, like git.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

coveralls commented May 23, 2024 •
edited
Loading

Coverage Status

coverage: 86.575% (+0.08%) from 86.5%
when pulling b5dba9c on fix/dpnp_mp
into b9436c1 on main.

@ZzEeKkAa ZzEeKkAa changed the title Fix/dpnp mp Remove versioneer, organize dpnp monkey patch May 23, 2024
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review May 23, 2024 23:00
diptorupd
diptorupd reviewed May 24, 2024
View reviewed changes
numba_dpex/core/typing/dpnpdecl.py
@@ -25,7 +22,7 @@ def _install_operations(cls: NumpyRulesArrayOperator):
for op, ufunc_name in cls._op_map.items():
infer_global(op)(
type(
"NumpyRulesArrayOperator_" + ufunc_name,
"DpnpRulesArrayOperator_" + ufunc_name,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

diptorupd
diptorupd approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes!

@diptorupd diptorupd merged commit f703390 into main May 24, 2024
73 of 75 checks passed
@diptorupd diptorupd deleted the fix/dpnp_mp branch May 24, 2024 00:55
github-actions bot added a commit that referenced this pull request May 24, 2024
@github-actions
Merge pull request #1464 from IntelPython/fix/dpnp_mp
04766d1 
Remove versioneer, organize dpnp monkey patch f703390
github-actions bot added a commit to ZzEeKkAa/numba-dpex that referenced this pull request May 24, 2024
@github-actions
Merge pull request IntelPython#1464 from IntelPython/fix/dpnp_mp
7cc3302 
Remove versioneer, organize dpnp monkey patch f703390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZzEeKkAa @coveralls @diptorupd