Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip test_solve with 3D matrix for numpy 2.0 #2126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip test_solve with 3D matrix for numpy 2.0 #2126

wants to merge 1 commit into from
+7 −2

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests skipping test_solve with 3D_Matrix_and_Vectors in test_sycl_queue.py until dpnp.linalg.solve() is updated to support numpy>=2.0

Also removes skip for SAT-6842 due to irrelevance (Issue has been fixed)

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vlad-perevezentsev