Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rtol kwarg to dpnp.linalg.pinv and dpnp.linalg.matrix_rank #2124

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add rtol kwarg to dpnp.linalg.pinv and dpnp.linalg.matrix_rank #2124

wants to merge 4 commits into from
+111 −23

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 24, 2024

In this PR, rtol kwarg is added to dpnp.linalg.pinv and dpnp.linalg.matrix_rank to align with NumPy 2.0.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/2124/index.html

@vtavana vtavana marked this pull request as ready for review October 25, 2024 01:59
antonwolfy
antonwolfy reviewed Oct 25, 2024
View reviewed changes
dpnp/linalg/dpnp_iface_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_iface_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_utils_linalg.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy left review comments

@npolina4 npolina4 Awaiting requested review from npolina4 npolina4 is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy