-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integer datatypes and add types to tests #2097
base: extended_types_support
Are you sure you want to change the base?
Add integer datatypes and add types to tests #2097
Conversation
166978a
to
1ef0be5
Compare
1ef0be5
to
8842fa6
Compare
export DPNP_TEST_ALL_TYPES=1 | ||
python -m pytest -n auto -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }} | ||
working-directory: ${{ env.tests-path }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same can be done through env
option:
export DPNP_TEST_ALL_TYPES=1 | |
python -m pytest -n auto -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }} | |
working-directory: ${{ env.tests-path }} | |
python -m pytest -n auto -q -ra --disable-warnings -vv ${{ env.TEST_SCOPE }} | |
working-directory: ${{ env.tests-path }} | |
env: | |
DPNP_TEST_ALL_TYPES: 1 |
"int32", | ||
"int64", | ||
"uint8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add uint
, uintc
, unitp
also
"uint8", | ||
"uint16", | ||
"uint32", | ||
"uint64", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to sort the names based on lexicographical order.
"int32", | ||
"int64", | ||
"uint8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NumPy also provides aliases, like: ubyte
, ushort
, ulong
and similar (full list here: numpy/_core/numerictypes.pyi
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the list of supported type in documentation, please check doc/reference/dtypes_table.rst
int8
,int16
,uint8
-uint64
) to dpnp interfaceDPNP_TEST_ALL_INTEGER_TYPES
to enable/disable these types in testsFailing dpnp tests: