Apply fallback to numpy for all unsupported functions on cuda devices. #2075
+771
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2075/index.html |
ndgrigorian
reviewed
Sep 25, 2024
antonwolfy
reviewed
Sep 26, 2024
npolina4
requested review from
vlad-perevezentsev and
vtavana
as code owners
antonwolfy
reviewed
Oct 16, 2024
antonwolfy
reviewed
Oct 25, 2024
| Returns | ||
| ------- | ||
| out : bool | ||
| Return ``True`` if object has a cuda backend, otherwise``False``. |
There was a problem hiding this comment.
Suggested change
| Return ``True`` if object has a cuda backend, otherwise``False``. | |
| Return ``True`` if object has a CUDA backend, otherwise ``False``. |
| @@ -11,24 +11,18 @@ | |||
|
|
|||
| def _gen_array(dtype, alloc_q=None): | |||
There was a problem hiding this comment.
Suggested change
| def _gen_array(dtype, alloc_q=None): | |
| # TODO: to roll back the changes once the issue with CUDA support is resolved for random | |
| def _gen_array(dtype, alloc_q=None): |
| @@ -11,6 +11,7 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.usefixtures("allow_fall_back_on_numpy") | |||
There was a problem hiding this comment.
dpnp.median has been implemented in #2117
Suggested change
| @pytest.mark.usefixtures("allow_fall_back_on_numpy") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply fallback to numpy for all unsupported functions on CUDA devices.
Added tests/skipped_tests_cuda.tbl