Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement dpnp.ndim and dpnp.size #2014

Merged
merged 5 commits into from
Aug 27, 2024
Merged

implement dpnp.ndim and dpnp.size #2014

merged 5 commits into from
Aug 27, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 26, 2024 •
edited
Loading

In this PR, dpnp.ndim and dpnp.size are implemented and docstring of dpnp.ndarray.ndim and dpnp.ndarray.size are updated.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 26, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review August 27, 2024 02:13
@vtavana vtavana changed the title implement dpnp.ndim implement dpnp.ndim and dpnp.size Aug 27, 2024
npolina4
npolina4 reviewed Aug 27, 2024
View reviewed changes
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
dpnp/dpnp_array.py Show resolved Hide resolved
npolina4
npolina4 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@npolina4 npolina4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana!

@vtavana vtavana merged commit 2f9b2fa into master Aug 27, 2024
39 of 46 checks passed
@vtavana vtavana deleted the impl_ndim branch August 27, 2024 23:55
github-actions bot added a commit that referenced this pull request Aug 28, 2024
@github-actions
implement dpnp.ndim and dpnp.size (#2014)
03d13d5 
* implement dpnp.ndim

* rename direcotry

* implement dpnp.size

* remove parameters section 2f9b2fa
@antonwolfy antonwolfy mentioned this pull request Sep 13, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @npolina4