Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tests for dpnp.einsum and adopt it with NumPy-2.0.0 #2012

Merged
merged 6 commits into from
Aug 27, 2024
Merged

Add new tests for dpnp.einsum and adopt it with NumPy-2.0.0 #2012

merged 6 commits into from
Aug 27, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 24, 2024 •
edited
Loading

In this PR,

  1. new tests are added for dpnp.einsum and accordingly a few updates are made in the code to pass all the test.
  2. The tests are update to pass with any numpy version between 1.23 and 2.0.
  3. docsting of several functions are updated to be consistent with each other.
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 24, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

npolina4
npolina4 reviewed Aug 27, 2024
View reviewed changes
dpnp/dpnp_utils/dpnp_utils_einsum.py Show resolved Hide resolved
dpnp/dpnp_utils/dpnp_utils_einsum.py Outdated Show resolved Hide resolved
dpnp/dpnp_utils/dpnp_utils_einsum.py Show resolved Hide resolved
npolina4
npolina4 approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@npolina4 npolina4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana!

@vtavana vtavana merged commit 75bb4e7 into master Aug 27, 2024
38 of 46 checks passed
@vtavana vtavana deleted the einsum_numpy2 branch August 27, 2024 21:09
github-actions bot added a commit that referenced this pull request Aug 27, 2024
@github-actions
Add new tests for dpnp.einsum and adopt it with NumPy-2.0.0 (#2012)
8d94032 
* update docstring

* add new tests

* update tests

* address comment

* align the code with NumPy 1.26

* use formatted string for Error msg 75bb4e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 approved these changes

@antonwolfy antonwolfy Awaiting requested review from antonwolfy antonwolfy is a code owner

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @npolina4