Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MACEWrapper interface changes #319

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

laserkelvin
Copy link
Collaborator

This PR changes how atomic_energies are treated in the wrapper, supporting dict mappings and generally better documentation in the docstring to describe what arguments are used where.

@laserkelvin laserkelvin added documentation Improvements or additions to documentation enhancement New feature or request code maintenance Issue/PR for refactors, code clean up, etc. labels Nov 18, 2024
Copy link
Collaborator

@melo-gonzo melo-gonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laserkelvin laserkelvin merged commit e446eea into IntelLabs:main Nov 18, 2024
2 of 3 checks passed
@laserkelvin laserkelvin deleted the mace-interface-changes branch November 18, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code maintenance Issue/PR for refactors, code clean up, etc. documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants