Lightning Refactor: pytorch_lightning -> lightning.pytorch
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melo-gonzo
changed the title
pytorch_lightning -> 'lightning.pytorch'pytorch_lightning -> lightning.pytorch
6 tasks
laserkelvin
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Functionally it looks good to me. Just left the one comment, and should be good to go from there.
I also linked with #297 - please unlink if you don't think it fully addresses it
There was a problem hiding this comment.
Did something change with these files?
There was a problem hiding this comment.
I think they were regenerated when i ran tests locally. i reverted to the old files.
|
LGTM, ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr migrated the pytorch lightning dependency from
pytorch_lightningtolightningand replaces the imports. Since this pr touches a lot of files, there are some formatting changes, and just a few updates to tests, mostly to add a missing argument for MACE.Failing tests are mostly due to materials project trajectory dataset not having a devset, and some with SAM which have been failing in recent PR's. Also I did not fix any pre-commit related items dealing with
cdvaethings.