This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Disable mandatory decoding with utf-8 #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives ability to use utf-16, for example in case of using powershell.
adydychk
requested review from
azhogov,
akharche,
dlobanox,
dimakozlov and
eponomar
as code owners
dlobanox
reviewed
Jun 5, 2019
| @@ -649,7 +649,6 @@ def cmd_exec(cmd, env=None, cwd=None, shell=True, log=None, verbose=True, hide=N | |||
| check=True, | |||
| stdout=subprocess.PIPE, | |||
| stderr=subprocess.STDOUT, | |||
| encoding='utf-8', | |||
There was a problem hiding this comment.
It's not quite good idea to disable encoding.
Need to be shure that output has correct format.
There was a problem hiding this comment.
I agree. Should be added default parameter in this case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives ability to use utf-16 without the errors, for example in case of using powershell.