No "Unit" in the Sensor items on the dbus

[wvervoorn]

Hello,

Normally the dbus item for a sensor contains a "Unit" for the value.

When I list this on the wolfpass openbmc this isn't present.

What I mean by "Unit" is a line line this: "Unit": "xyz.openbmc_project.Sensor.Value.Unit.RPMS"

Below is an exapmle of what I get.

Is this expected in this version? How can this be corrected? Should something specific be added to the baseboard.json?

In my case the WebUI doesn't show any sensor data. As far as I can see this is because of this issue. How can this be solved or is this something that is know already and will be solved in a next release?

Best regards,

Wim Vervoorn

"/xyz/openbmc_project/sensors/temperature/CPU1_P12V_PVCCIN_VR_Temp": {
  "CriticalAlarmHigh": false,
  "CriticalAlarmLow": false,
  "CriticalHigh": 115.0,
  "CriticalLow": 0.0,
  "MaxValue": 255.0,
  "MinValue": 0.0,
  "Value": 0.0,
  "WarningAlarmHigh": false,
  "WarningAlarmLow": false,
  "WarningHigh": 110.0,
  "WarningLow": 5.0,
  "associations": [
    [
      "inventory",
      "sensors",
      "/xyz/openbmc_project/inventory/system/board/WFP_Baseboard/CPU1_P12V_PVCCIN_VR_Temp"
    ]
  ] 

[feistjj]

dbus-sensors does not provide "unit" because generally the unit can easily be looked up from the dbus-path so it seemed redundant i.e. /xyz/openbmc_project/sensors/temperature is degrees C, /xyz/openbmc_project/sensors/voltage is Volts, etc.

[wvervoorn]

Hello James, Thanks for the quick response. I agree with you that this is easy to do. The issue is that as far as I can see the phosphor-webui is still using this when it enumerates the sensors. (app/common/services/api_utils.js) In “getSensorStatus”, am I interpreting this code in the wrong way or is this in the process of being updates as well? Best Regards, Wim Vervoorn Eltan B.V. Ambachtstraat 23 5481 SM Schijndel The Netherlands T : +31-(0)73-594 46 64 E : [email protected] W : http://www.eltan.com<http://www.eltan.com/> "THIS MESSAGE CONTAINS CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE +31-(0)73-5944664 OR REPLY EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES." From: James Feist [mailto:[email protected]] Sent: Thursday, March 28, 2019 5:08 PM To: Intel-BMC/openbmc <[email protected]> Cc: Wim Vervoorn <[email protected]>; Author <[email protected]> Subject: Re: [Intel-BMC/openbmc] No "Unit" in the Sensor items on the dbus (#6) dbus-sensors does not provide "unit" because generally the unit can easily be looked up from the dbus-path so it seemed redundant i.e. /xyz/openbmc_project/sensors/temperature is degrees C, /xyz/openbmc_project/sensors/voltage is Volts, etc. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#6 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIij3NopLBZY8rJRcSnedRoPmDQN206Vks5vbOjNgaJpZM4cQMcL>.

[edtanous]

We've just recently enabled the webui in our builds, and are working through some of the issues there. This is one of the ones that is an issue.
Please see the patch below, which should move the interfaces to redfish, and away from the dbus API, which is the long term goal.
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/17745

[wvervoorn]

Hello Ed, Thanks for the update. Now it makes sense. A more or less related question is there anywhere I can find information about the status of the tree so that I don’t have to bother you again with this type of questions? Best Regards, Wim Vervoorn Eltan B.V. Ambachtstraat 23 5481 SM Schijndel The Netherlands T : +31-(0)73-594 46 64 E : [email protected] W : http://www.eltan.com<http://www.eltan.com/> "THIS MESSAGE CONTAINS CONFIDENTIAL INFORMATION. UNLESS YOU ARE THE INTENDED RECIPIENT OF THIS MESSAGE, ANY USE OF THIS MESSAGE IS STRICTLY PROHIBITED. IF YOU HAVE RECEIVED THIS MESSAGE IN ERROR, PLEASE IMMEDIATELY NOTIFY THE SENDER BY TELEPHONE +31-(0)73-5944664 OR REPLY EMAIL, AND IMMEDIATELY DELETE THIS MESSAGE AND ALL COPIES." From: Ed Tanous [mailto:[email protected]] Sent: Thursday, March 28, 2019 6:08 PM To: Intel-BMC/openbmc <[email protected]> Cc: Wim Vervoorn <[email protected]>; Author <[email protected]> Subject: Re: [Intel-BMC/openbmc] No "Unit" in the Sensor items on the dbus (#6) We've just recently enabled the webui in our builds, and are working through some of the issues there. This is one of the ones that is an issue. Please see the patch below, which should move the interfaces to redfish, and away from the dbus API, which is the long term goal. https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-webui/+/17745 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#6 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIij3GT50p19V_5VnAE54PcvFnH9OwrHks5vbPb9gaJpZM4cQMcL>.