Поддержка гостевого доступа для страницы со статистикой #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by generating a jwt and including it in the link
Artem-Rzhankoff
force-pushed
the
student-stat-chart-token
branch
from
a09f004 to
0c07e3d
Compare
DedSec256
reviewed
Jun 7, 2024
HwProj.APIGateway/HwProj.APIGateway.API/Controllers/StatisticsController.cs
Show resolved
Hide resolved
DedSec256
reviewed
Jun 7, 2024
| public async Task<Solution[]> GetTaskSolutionsFromGroup(long groupId, long taskId) | ||
| { | ||
| return await _solutionsService.GetTaskSolutionsFromGroupAsync(taskId, groupId); | ||
| } | ||
|
|
||
| [HttpGet("getLecturersStat/{courseId}")] | ||
| [Authorize(AuthenticationSchemes = AuthSchemeConstants.UserIdAuthentication)] |
There was a problem hiding this comment.
из-за одного метода не хотелось бы править все остальные
DedSec256
reviewed
Jun 7, 2024
| @@ -181,6 +192,7 @@ public async Task<IActionResult> GetLecturersStat(long courseId) | |||
| } | |||
|
|
|||
| [HttpGet("getCourseStat/{courseId}")] | |||
| [Authorize(AuthenticationSchemes = AuthSchemeConstants.GuestModeOrUseridAuthentication)] | |||
There was a problem hiding this comment.
не хотелось бы давать здесь доступа больше, чем нужно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Преподаватель может делиться статистикой с неавторизованными пользователями посредством ссылки, содержащей токен для получения необходимого доступа.
