-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pip modularization changes to "end of may work in progress" #16
Open
jonathanhhb
wants to merge
31
commits into
jbloedow/end_of_may_wip
Choose a base branch
from
jb_modulify
base: jbloedow/end_of_may_wip
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m to data outside of idmlaser.
…error messages to user about what to do. The idea is to enable users to get going by trial and error. The build_template_workspace utility mentioned in the error message does not exist yet. Coming soon.
… that came up in testing.
…e column/attribute/property (age).
…re but at least what's there isn't wrong.
…dd more but at least what's there isn't wrong.
…t. This runs without errors but I'm not sure if we need more clarity to user.
…ly unused functions in sir_numpy.py; 3) Added detailed doc strings to used functions. 4) Added schema.json and code to key off that so as to avoid hardcoding properties schema.
…_report and no longer count up in calculate_new_infections. Also fixes a bug in 'exposed' counting. Adds Exposed 'channel' to output report. Replaced 'infections' count with 'infectious count' in various places. Needs testing.
…brating. Started adding some comments to update_ages functions to explain non-use of expected_lifespan.
…ng is no longer really being used.
… the c code. Also starting adding ability to pass in incubation duration to C function which does new infections.
…ful for calibratoin.
… anymore. (After getting sweeps working in COMPS.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should rename to "end of June WIP" I guess. :? Naming things well is hard.
I'd like to consolidate the last month's work. But there's still outstanding documentation (notebooks) that align with jbloedow/end_of_may_wip and merging this now will make those notebooks obsolete in an annoying way.