Skip to content

Commit

Permalink
Fix artist image on Safari
Browse files Browse the repository at this point in the history
Ahhh yes, here we see a wild Safari, being completely broken and not working like every other browser.

Previously, when the viewport got small on Safari, the image would take up the entire background.

This is a little hacky, causing the image to not scale correctly on some very specific screen sizes, and ideally we'll come up with a better solution, but this gets the job done for now.
  • Loading branch information
Insprill committed May 9, 2023
1 parent c49caea commit bf3715a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

# 0.x.x:
- Fixed the artist image taking up the entire backgound on small Safari viewports.
- Fixed image URL on the artist page not being URL encoded.


Expand Down
10 changes: 8 additions & 2 deletions static/style/artist.css
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,16 @@
grid-area: image;
object-fit: cover;
width: 100%;
height: 100%;
max-height: 100%;
border-radius: var(--radius);
}

@media only screen and (min-width: 513px) {
.artist-image {
height: 100%;
}
}

.artist-info {
grid-area: name;
display: grid;
Expand Down Expand Up @@ -149,7 +155,7 @@
grid-template-rows: auto;
grid-template-areas:
"image name"
"imagesocial"
"image social"
"description description"
"songs songs";
}
Expand Down

0 comments on commit bf3715a

Please sign in to comment.