Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for getters #587

Merged
merged 19 commits into from
Nov 30, 2023
Merged

Add support for getters #587

merged 19 commits into from
Nov 30, 2023

Commits on Nov 30, 2023

  1. ENH: Add getters 

    Getters are designed with the expectation that they will be called twice. On the
first pass the getter is added to a queue and a callback function is set on each.
Once the getter resolves the result is set in the results dict and getters are
ready to be called again to return their result.
    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    aec5993 View commit details
    Browse the repository at this point in the history

  2. DOC: Add getter example to Hello3DWorld notebook

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    9a998a0 View commit details
    Browse the repository at this point in the history

  3. ENH: Listen to pre_run_cell signal 

    This allows us to grab the cell id and raw cell string for re-running cells
with getters.
    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e1a74b7 View commit details
    Browse the repository at this point in the history

  4. ENH: Build a CellWatcher class to monitor cells before running 

    Intercept execute_requests (which will be all cells queued to run after the
Viewer class has been instantiated. Once the itk_viewer has been created the
queue is processed one request at a time. If a cell contains getters, futures
are created for each and a callback function is set to set the result as they
resolve. Once all of the results are set the cell is run and the queue
continues to be processed.
    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    4d4464e View commit details
    Browse the repository at this point in the history

  5. MAINT: Refactor getters into decorator

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    0f59c64 View commit details
    Browse the repository at this point in the history

  6. BUG: Force exceptions to bubble up and interrupt notebook

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6b77217 View commit details
    Browse the repository at this point in the history

  7. ENH: Run the cell and then wait for getters to resolve

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    4138f47 View commit details
    Browse the repository at this point in the history

  8. MAINT: Simplify callback for getters

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6b03793 View commit details
    Browse the repository at this point in the history

  9. ENH: Do not use background thread for setters

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    06aa218 View commit details
    Browse the repository at this point in the history

  10. ENH: Make CellWatcher class a singleton

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    cba9c04 View commit details
    Browse the repository at this point in the history

  11. ENH: Use Viewers class to manage all Viewer instances

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    44e9913 View commit details
    Browse the repository at this point in the history

  12. DOC: Add more detailed comments

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    1915084 View commit details
    Browse the repository at this point in the history

  13. BUG: Abort all queued cells if an exception is thrown

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e6f0bcc View commit details
    Browse the repository at this point in the history

  14. ENH: Add missing getter get_layer_names

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c2783ca View commit details
    Browse the repository at this point in the history

  15. BUG: Fix logic for executing next request 

    If we have a current request when the queue is empty we still need to execute
that cell.
    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    d0c41c2 View commit details
    Browse the repository at this point in the history

  16. ENH: Update the list of deferred methods

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    916dd5c View commit details
    Browse the repository at this point in the history

  17. DOC: Add notebook specifically for testing getters/setters

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    397fc00 View commit details
    Browse the repository at this point in the history

  18. BUG: Add missing global variable back in

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    2218712 View commit details
    Browse the repository at this point in the history

  19. BUG: Update Viewer status before call_soon

    @bnmajor
    bnmajor committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    a0b8352 View commit details
    Browse the repository at this point in the history