Skip to content

Commit

Permalink
Merge pull request #696 from bnmajor/getters-docs
Browse files Browse the repository at this point in the history
DOC: Add documentation about current getters support
  • Loading branch information
thewtex authored Nov 30, 2023
2 parents 3f01065 + 71b6be1 commit 34e32ce
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
29 changes: 29 additions & 0 deletions docs/advanced.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# Advanced
----------

## Returning Values

Communication with the IPython Kernel is asynchronous, which causes challenges with Python code blocks in Jupyter cells that run synchronously. Multiple comm messages cannot be awaited during the synchronous Python code block execution. With regards to ITKWidgets this means that getter functions do not "just work" - the Python code cannot complete until the comm message has resolved with the response and the message cannot resolve until the code has completed. This creates a deadlock that prevents the kernel from progressing. This has been a [documented issue for the Jupyter ipykernel](https://github.com/ipython/ipykernel/issues/65) for many years.

Libraries like [ipython_blocking](https://github.com/kafonek/ipython_blocking) and [jupyter-ui-poll](https://github.com/Kirill888/jupyter-ui-poll) have made efforts to address this issue and their approaches have been a great source of inspiration for the custom solution that we have chosen for ITKWidgets.

Our current solution prevents deadlocks but requires that getters be requested in one cell and resolved in another. For example:

```python
viewer = view(image)
```
```python
bg_color = viewer.get_background_color()
print(bg_color)
```
would simply become:

```python
viewer = view(image)
```
```python
bg_color = viewer.get_background_color()
```
```python
print(bg_color)
```
1 change: 1 addition & 0 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ quick_start_guide.rst
deployments.rst
integrations.rst
development.rst
advanced.rst
```

0 comments on commit 34e32ce

Please sign in to comment.