Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pflock #938

Merged
merged 5 commits into from
Sep 18, 2023
Merged

pflock #938

merged 5 commits into from
Sep 18, 2023

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Sep 17, 2023

  • build: WASI hdf5 support for missing Pflock symbol
  • build: Remove HDF5 wasi thread_local workaround
  • build: Work around H5DataSpace WASI missing symbol
  • build: Improve HDF5 Initialization
  • feat(itk-wasm-cli): Update default Docker image for 20230917-38fb6f92

@thewtex
build: WASI hdf5 support for missing Pflock symbol
e7bc079
@thewtex
build: Remove HDF5 wasi thread_local workaround
89bcc5b
@thewtex
build: Work around H5DataSpace WASI missing symbol
b956eed
@thewtex
build: Improve HDF5 Initialization
38fb6f9 
To address:

```
At: DataSpace::getConstantDataSpace::getConstant is being invoked on an allocated ALL_Error: failed to run main module `wasi-build/elastix.wasi.wasm`

Caused by:
    0: failed to invoke command default
    1: error while executing at wasm backtrace:
           0: 0xf1ee0 - <unknown>!abort
           1: 0x72844e - <unknown>!_GLOBAL__sub_I_H5DataSpace.cpp
           2: 0x4282d - <unknown>!__wasm_call_ctors
           3: 0x1683ed1 - _initialize_local
                           at /ITKWebAssemblyInterface/src/initialization.cxx:59:5
           4: 0x1683e8b - _start
                           at /ITKWebAssemblyInterface/src/initialization.cxx:90:3
    2: wasm trap: wasm `unreachable` instruction executed
```
@thewtex
feat(itk-wasm-cli): Update default Docker image for 20230917-38fb6f92
f71ae37
@thewtex
Copy link
Member Author

thewtex commented Sep 18, 2023

Failing CI check addressed in #940.

@thewtex thewtex merged commit 94096c5 into InsightSoftwareConsortium:main Sep 18, 2023
@thewtex thewtex deleted the pflock branch September 18, 2023 20:14
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-b.139 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thewtex