build(cmake): set download_extract_timestamp to true
#936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhlegarreta
force-pushed
the
FixExtractTimestampCMakePolicyWarnings
branch
from
32cf239 to
7b83ec5
Compare
jhlegarreta
changed the title
download_extract_timestamp to truedownload_extract_timestamp to true
|
A number of other CMake warnings are present in the GHA workflow log: But are not reported to CDash. Not sure why. They may well deserve some attention. |
Set `DOWNLOAD_EXTRACT_TIMESTAMP` to `TRUE`: the timestamps of the extracted files will reflect the timestamps in the archive. Fixes: ``` CMake Warning (dev) at D:/a/_temp/-2103337693/cmake-3.24.2-windows-x86_64/share/cmake-3.24/Modules/ExternalProject.cmake:3074 (message): The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is not set. The policy's OLD behavior will be used. When using a URL download, the timestamps of extracted files should preferably be that of the time of extraction, otherwise code that depends on the extracted contents might not be rebuilt if the URL changes. The OLD behavior preserves the timestamps from the archive instead, but this is usually not what you want. Update your project to the NEW behavior or specify the DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this robustness issue. ``` raised for exmaple in: https://open.cdash.org/build/8983547/configure Related documentation: https://cmake.org/cmake/help/latest/module/ExternalProject.html?highlight=download_extract_timestamp https://cmake.org/cmake/help/latest/policy/CMP0135.html
jhlegarreta
force-pushed
the
FixExtractTimestampCMakePolicyWarnings
branch
from
7b83ec5 to
5ca66d6
Compare
jhlegarreta
commented
Sep 16, 2023
| set(download_extract_timestamp_flag) | ||
| else() | ||
| set(download_extract_timestamp_flag DOWNLOAD_EXTRACT_TIMESTAMP TRUE) | ||
| endif() |
There was a problem hiding this comment.
Not sure if this is the appropriate place within the file.
There was a problem hiding this comment.
Looks like it did not work:
https://open.cdash.org/index.php?project=Insight&date=2023-09-16
Cross-referencing InsightSoftwareConsortium/ITKElastix#248 (comment)
thewtex
approved these changes
Sep 18, 2023
| set(download_extract_timestamp_flag) | ||
| else() | ||
| set(download_extract_timestamp_flag DOWNLOAD_EXTRACT_TIMESTAMP TRUE) | ||
| endif() |
|
Failing CI check addressed in #940. |
|
🎉 This PR is included in version 1.0.0-b.139 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
DOWNLOAD_EXTRACT_TIMESTAMPtoTRUE: the timestamps of the extracted files will reflect the timestamps in the archive.Fixes:
raised for exmaple in:
https://open.cdash.org/build/8983547/configure
Related documentation:
https://cmake.org/cmake/help/latest/module/ExternalProject.html?highlight=download_extract_timestamp https://cmake.org/cmake/help/latest/policy/CMP0135.html