Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make ubuntu versions consistent across workflow file jobs #934

Conversation

jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Sep 16, 2023

  • ci: make ubuntu versions consistent across workflow file jobs
  • ci: use GitHub Action to free up disk space

@jhlegarreta
Copy link
Member Author

Cross-referencing #907 (comment).

Notes about the commit message:

  • Used commitizen to create the commit using cz commit. Hope this is the correct way.
  • cz commit recommended to keep the subject to all lowercases. Let me know if we follow that here.
  • cz commit does not seem to enforce a new line at e.g. 72 characters. Let me know if a line length limit is used here, and if so, how to configure that.

Thanks.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI catches updates needed in the "Free up disk space" sections of the CI configurations

@thewtex
Copy link
Member

thewtex commented Sep 18, 2023

Thank you Jon Haitz @jhlegarreta !

It looks like the clean-up disk space steps need to be updated for Ubuntu 22.04.

Used commitizen to create the commit using cz commit. Hope this is the correct way.

That works.

cz commit recommended to keep the subject to all lowercases. Let me know if we follow that here.

Currently we support all lowercase but also starting the subject with a capital, e.g. ci: make ubuntu versions consistent or ci: Make ubuntu versions consistent.

cz commit does not seem to enforce a new line at e.g. 72 characters. Let me know if a line length limit is used here, and if so, how to configure that.

There is a line length of 300, configured here: https://github.com/InsightSoftwareConsortium/itk-wasm/blob/b1289e36d0b2483c8687d9325fb16ed604be4b15/package.json#L242-L245

for pasting long error messages. CI will fail if that is exceeded.

@jhlegarreta jhlegarreta force-pushed the MakeUbuntuVersionsConsistent branch from 72b5868 to 0558703 Compare September 18, 2023 23:56
@jhlegarreta
Copy link
Member Author

It looks like the clean-up disk space steps need to be updated for Ubuntu 22.04.

See if 0558703 makes the trick.

Currently we support all lowercase but also starting the subject with a capital, e.g. ci: make ubuntu versions consistent or ci: Make ubuntu versions consistent.

OK.

There is a line length of 300, configured here:

OK.

@jhlegarreta jhlegarreta force-pushed the MakeUbuntuVersionsConsistent branch from 0558703 to 08e1615 Compare September 19, 2023 00:33
@jhlegarreta
Copy link
Member Author

See if 0558703 makes the trick.

The disk space issue is still not solved:
https://github.com/InsightSoftwareConsortium/itk-wasm/actions/runs/6229582807/job/16908321942?pr=934

@thewtex
Copy link
Member

thewtex commented Sep 19, 2023

Perhaps an apt-get update is needed to update mirror contents?

@jhlegarreta
Copy link
Member Author

Perhaps an apt-get update is needed to update mirror contents?

I added update calls across different workflow files, and e.g. Javascript, Typescript already had it:
https://github.com/InsightSoftwareConsortium/itk-wasm/pull/934/files#diff-793ac937203aa651a9ef26407f8d833b8deb9e300d493a1ad80ba705ef9de145L16

@thewtex
Copy link
Member

thewtex commented Sep 19, 2023

Seems to working in the others, but the Javascript, Typescript looks to need updates.

@thewtex thewtex force-pushed the MakeUbuntuVersionsConsistent branch 4 times, most recently from 5134947 to f1f9b4e Compare September 29, 2023 20:11
Make Ubuntu versions consistent across workflow file jobs: use
`ubuntu-22.04`.
@jhlegarreta jhlegarreta force-pushed the MakeUbuntuVersionsConsistent branch from f1f9b4e to 3aa19be Compare September 29, 2023 23:00
@jhlegarreta
Copy link
Member Author

Reworded my commit message to honor its changes, as freeing disk space is now addressed in a separate commit.

Community effort is more maintainable.
@thewtex thewtex force-pushed the MakeUbuntuVersionsConsistent branch from 3aa19be to 55166f1 Compare September 30, 2023 14:59
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @jhlegarreta for your awesome work on this!

The remaining failing CI check was addressed in main by 8a9925b

@thewtex thewtex merged commit a9bec9b into InsightSoftwareConsortium:main Sep 30, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-b.146 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jhlegarreta jhlegarreta deleted the MakeUbuntuVersionsConsistent branch October 1, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants