-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: make ubuntu versions consistent across workflow file jobs #934
ci: make ubuntu versions consistent across workflow file jobs #934
Conversation
jhlegarreta
commented
Sep 16, 2023
•
edited
Loading
edited
- ci: make ubuntu versions consistent across workflow file jobs
- ci: use GitHub Action to free up disk space
Cross-referencing #907 (comment). Notes about the commit message:
Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI catches updates needed in the "Free up disk space" sections of the CI configurations
Thank you Jon Haitz @jhlegarreta ! It looks like the clean-up disk space steps need to be updated for Ubuntu 22.04.
That works.
Currently we support all lowercase but also starting the subject with a capital, e.g.
There is a line length of 300, configured here: https://github.com/InsightSoftwareConsortium/itk-wasm/blob/b1289e36d0b2483c8687d9325fb16ed604be4b15/package.json#L242-L245 for pasting long error messages. CI will fail if that is exceeded. |
72b5868
to
0558703
Compare
See if 0558703 makes the trick.
OK.
OK. |
0558703
to
08e1615
Compare
The disk space issue is still not solved: |
Perhaps an |
I added update calls across different workflow files, and e.g. |
Seems to working in the others, but the |
5134947
to
f1f9b4e
Compare
Make Ubuntu versions consistent across workflow file jobs: use `ubuntu-22.04`.
f1f9b4e
to
3aa19be
Compare
Reworded my commit message to honor its changes, as freeing disk space is now addressed in a separate commit. |
Community effort is more maintainable.
3aa19be
to
55166f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @jhlegarreta for your awesome work on this!
The remaining failing CI check was addressed in main
by 8a9925b
🎉 This PR is included in version 1.0.0-b.146 🎉 The release is available on:
Your semantic-release bot 📦🚀 |