Skip to content

Commit

Permalink
ci(python-wasm): only test pyodide on ubuntu-22.04
Browse files Browse the repository at this point in the history
This is currently an incompatibility between the selenium and Chrome
versions on Windows:

```
----------------------------- Captured log setup ------------------------------
WARNING  selenium.webdriver.common.selenium_manager:selenium_manager.py:138 The chromedriver version (133.0.6888.0) detected in PATH at C:\hostedtoolcache\windows\setup-chrome\chromedriver\1393741\x64\chromedriver.exe might not be compatible with the detected chrome version (131.0.6778.86); currently, chromedriver 131.0.6778.87 is recommended for chrome 131.*, so it is advised to delete the driver in PATH and retry
=========================== short test summary info ===========================
ERROR test/test_compress_stringify.py::test_example[chrome] - selenium.common.exceptions.SessionNotCreatedException: Message: session not created: This version of ChromeDriver only supports Chrome version 133
Current browser version is 131.0.6778.86 with binary path C:\Program Files\Google\Chrome\Application\chrome.exe
Stacktrace:
	GetHandleVerifier [0x00007FF66A01C635+53269]
	simdutf::get_active_implementation [0x00007FF669E5D3B7+1684007]
	(No symbol) [0x00007FF669AFE09B]
	(No symbol) [0x00007FF669B43DB9]
	(No symbol) [0x00007FF669B42C00]
	(No symbol) [0x00007FF669B3D79D]
```
  • Loading branch information
thewtex committed Dec 9, 2024
1 parent de8f11b commit 81090e0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/python-wasm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ jobs:
pnpm run --aggregate-output --filter "@itk-wasm/${{ matrix.package }}-build" test:python:wasi
- uses: thewtex/pyodide-actions/install-browser@1e32e8a037a3e99a845dd7ebad6b057a40b7e2c0
if: ${{ matrix.python-minor-version > 11 }}
if: ${{ matrix.python-minor-version > 11 && matrix.os == 'ubuntu-22.04' }}
with:
runner: selenium
browser: chrome
browser-version: latest

- name: Test python on chrome
if: ${{ matrix.python-minor-version > 11 && matrix.package != 'dicom' && matrix.os == 'ubuntu-22.04' || (matrix.package != 'mesh-io' && matrix.package != 'image-io' && matrix.package != 'dicom' && matrix.os != 'macos-14' )}}
if: ${{ matrix.python-minor-version > 11 && matrix.package != 'dicom' && matrix.os == 'ubuntu-22.04' }}
run: |
pnpm run --aggregate-output --filter "@itk-wasm/${{ matrix.package }}-build" test:python:emscripten

0 comments on commit 81090e0

Please sign in to comment.