Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] performance forEach on range #1992

Merged
merged 5 commits into from
Nov 15, 2024
Merged

[Maintenance] performance forEach on range #1992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eafb444
update KoinExtension.kt
JunJaBoy Jul 9, 2024
74f9198
Merge pull request #1913 from JunJaBoy/patch-2
arnaudgiuliani Sep 17, 2024
2eb9163
Merge branch 'InsertKoinIO:main' into main
GrzegorzBobryk Oct 27, 2024
ba22296
[Maintenance] performance `forEach` on range
GrzegorzBobryk Sep 22, 2024
5de2c7f
[Maintenance] performance `forEach` on range
GrzegorzBobryk Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions projects/core/koin-core-coroutines/src/jvmTest/kotlin/org/koin/test/PerfsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
package org.koin.test

import kotlinx.coroutines.runBlocking
import org.koin.core.*
import org.koin.core.context.GlobalContext.startKoin
import org.koin.core.context.GlobalContext.stopKoin
import org.koin.core.context.waitKoinStart
import org.koin.core.logger.*
import org.koin.core.isAllStartedJobsDone
import org.koin.core.lazyModules
import org.koin.core.logger.EmptyLogger
import org.koin.core.logger.Level
import org.koin.core.logger.Logger
import org.koin.core.onKoinStarted
import org.koin.core.runOnKoinStarted
import org.koin.core.time.Timer
import org.koin.core.waitAllStartJobs
import org.koin.dsl.koinApplication
import org.koin.mp.KoinPlatform
import kotlin.test.Test
Expand All @@ -15,12 +21,16 @@ class PerfsTest {

@Test
fun perfModule400_module_perfs() {
(1..3).forEach { runPerfs() }
for (index in 1..3) {
runPerfs()
}
}

@Test
fun perfModule400_lazy_module_perfs() {
(1..3).forEach { runPerfs(isLazy = true) }
for (index in 1..3) {
runPerfs(isLazy = true)
}
}

private fun runPerfs(log: Logger = EmptyLogger(), isLazy: Boolean = false) {
Expand Down
2 changes: 1 addition & 1 deletion projects/core/koin-core/src/commonTest/kotlin/org/koin/core/ParameterStackTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class ParameterStackTest {
)
}.koin

(1..10).forEach {
for (index in 1..10) {
koin.get<Simple.MyStringFactory> { parametersOf(KoinPlatformTools.generateId()) }
}

Expand Down
2 changes: 1 addition & 1 deletion projects/core/koin-core/src/jvmTest/kotlin/org/koin/core/DebugLogTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class DebugLogTest {
printLogger(Level.INFO)
}.koin

(1..10).forEach {
for (index in 1..10) {
measureDuration("with if") {
if (koin.logger.isAt(Level.DEBUG)) {
koin.logger.debug(message { "test me" })
Expand Down
6 changes: 4 additions & 2 deletions projects/core/koin-core/src/jvmTest/kotlin/org/koin/core/instance/CreateAPITest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
//package org.koin.core.instance
//
//import org.junit.Assert.*
//import org.junit.Assert.assertEquals
//import org.junit.Assert.assertNotEquals
//import org.junit.Assert.fail
//import org.junit.Test
//import org.koin.core.error.InstanceCreationException
//import org.koin.core.logger.Level
Expand Down Expand Up @@ -123,7 +125,7 @@
// )
// }.koin
//
// (1..3).forEach {
// for (index in 1..3) {
// koin.get<Component>()
// }
// }
Expand Down
Loading