Prepare ViewModel deprecation to go in koin-viewmodel module

InsertKoinIO · Jul 12, 2024 · e54fa9a · e54fa9a
1 parent 4177fa5
commit e54fa9a
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 1 deletion.
diff --git a/projects/android/koin-android/src/main/java/org/koin/androidx/viewmodel/dsl/ModuleExt.kt b/projects/android/koin-android/src/main/java/org/koin/androidx/viewmodel/dsl/ModuleExt.kt
@@ -23,6 +23,8 @@ import org.koin.core.instance.newInstance
 import org.koin.core.module.Module
 import org.koin.core.qualifier.Qualifier
 
+//TODO DEPRECATE in favor of koin-viewmodel to mutualise ViewModel DSL for Android and Compose
+
 /**
  * ViewModel DSL Extension
  * Allow to declare a ViewModel - be later inject into Activity/Fragment with dedicated injector

diff --git a/projects/android/koin-android/src/main/java/org/koin/androidx/viewmodel/dsl/ScopeSetExt.kt b/projects/android/koin-android/src/main/java/org/koin/androidx/viewmodel/dsl/ScopeSetExt.kt
@@ -23,6 +23,8 @@ import org.koin.core.instance.newInstance
 import org.koin.core.qualifier.Qualifier
 import org.koin.dsl.ScopeDSL
 
+//TODO DEPRECATE in favor of koin-viewmodel to mutualise ViewModel DSL for Android and Compose
+
 /**
  * ViewModel DSL Extension
  * Allow to declare a ViewModel - be later inject into Activity/Fragment with dedicated injector

diff --git a/...ts/android/koin-android/src/main/java/org/koin/androidx/viewmodel/dsl/ScopeViewModelOf.kt b/...ts/android/koin-android/src/main/java/org/koin/androidx/viewmodel/dsl/ScopeViewModelOf.kt
@@ -24,6 +24,8 @@ import org.koin.core.module.dsl.new
 import org.koin.core.module.dsl.onOptions
 import org.koin.dsl.ScopeDSL
 
+//TODO DEPRECATE in favor of koin-viewmodel to mutualise ViewModel DSL for Android and Compose
+
 /**
  * Declare a [ScopeDSL.viewModel] definition by resolving a constructor reference for the dependency.
  * The resolution is done at compile time by leveraging inline functions, no reflection is required.

diff --git a/projects/android/koin-android/src/main/java/org/koin/androidx/viewmodel/dsl/ViewModelOf.kt b/projects/android/koin-android/src/main/java/org/koin/androidx/viewmodel/dsl/ViewModelOf.kt
@@ -24,6 +24,8 @@ import org.koin.core.module.dsl.DefinitionOptions
 import org.koin.core.module.dsl.new
 import org.koin.core.module.dsl.onOptions
 
+//TODO DEPRECATE in favor of koin-viewmodel to mutualise ViewModel DSL for Android and Compose
+
 /**
  * Declare a [Module.viewModel] definition by resolving a constructor reference for the dependency.
  * The resolution is done at compile time by leveraging inline functions, no reflection is required.

diff --git a/.../koin-compose-viewmodel/src/commonMain/kotlin/org/koin/compose/viewmodel/dsl/ModuleExt.kt b/.../koin-compose-viewmodel/src/commonMain/kotlin/org/koin/compose/viewmodel/dsl/ModuleExt.kt
@@ -21,7 +21,7 @@ import org.koin.core.definition.KoinDefinition
 import org.koin.core.module.Module
 import org.koin.core.qualifier.Qualifier
 
-//TODO Ported from Android side
+//TODO DEPRECATE in favor of koin-viewmodel to mutualise ViewModel DSL for Android and Compose
 
 /**
  * ViewModel DSL Extension

diff --git a/...oin-compose-viewmodel/src/commonMain/kotlin/org/koin/compose/viewmodel/dsl/ScopeSetExt.kt b/...oin-compose-viewmodel/src/commonMain/kotlin/org/koin/compose/viewmodel/dsl/ScopeSetExt.kt
@@ -21,6 +21,8 @@ import org.koin.core.definition.KoinDefinition
 import org.koin.core.qualifier.Qualifier
 import org.koin.dsl.ScopeDSL
 
+//TODO DEPRECATE in favor of koin-viewmodel to mutualise ViewModel DSL for Android and Compose
+
 /**
  * ViewModel DSL Extension
  * Allow to declare a ViewModel - be later inject into Activity/Fragment with dedicated injector

diff --git a/...ompose-viewmodel/src/commonMain/kotlin/org/koin/compose/viewmodel/dsl/ScopeViewModelOf.kt b/...ompose-viewmodel/src/commonMain/kotlin/org/koin/compose/viewmodel/dsl/ScopeViewModelOf.kt
@@ -24,6 +24,8 @@ import org.koin.core.module.dsl.new
 import org.koin.core.module.dsl.onOptions
 import org.koin.dsl.ScopeDSL
 
+//TODO DEPRECATE in favor of koin-viewmodel to mutualise ViewModel DSL for Android and Compose
+
 /**
  * Declare a [ScopeDSL.viewModel] definition by resolving a constructor reference for the dependency.
  * The resolution is done at compile time by leveraging inline functions, no reflection is required.

diff --git a/...oin-compose-viewmodel/src/commonMain/kotlin/org/koin/compose/viewmodel/dsl/ViewModelOf.kt b/...oin-compose-viewmodel/src/commonMain/kotlin/org/koin/compose/viewmodel/dsl/ViewModelOf.kt
@@ -24,6 +24,8 @@ import org.koin.core.module.dsl.DefinitionOptions
 import org.koin.core.module.dsl.new
 import org.koin.core.module.dsl.onOptions
 
+//TODO DEPRECATE in favor of koin-viewmodel to mutualise ViewModel DSL for Android and Compose
+
 /**
  * Declare a [Module.viewModel] definition by resolving a constructor reference for the dependency.
  * The resolution is done at compile time by leveraging inline functions, no reflection is required.