Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniformize silent kwargs #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Uniformize silent kwargs #224

wants to merge 1 commit into from

Conversation

tgrandje
Copy link
Collaborator

  • add silent kwarg to all function using the save_df decorator
  • uniformize the default silent value everywhere
  • inherit silent values from parent functions everywhere

@tgrandje
Uniformize silent kwargs
a2a9349 
* add silent kwarg to all function using the save_df decorator
* uniformize the default silent value everywhere
* inherit silent values from parent functions everywhere
@tgrandje tgrandje self-assigned this Oct 14, 2024
@hadrilec
Copy link
Contributor

tbh, I am not sure that I want everything to be silenced by default

@tgrandje
Copy link
Collaborator Author

@hadrilec well, I was also not in favor of it, but most queries were already silenced. If we're ok that the default behaviour should be the invert, I'll do it. I still think we should have a consistent API, but that's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgrandje tgrandje

Labels
None yet
Projects
None yet
Milestone
https://github.com/InseeFrLab/pynsee/...
Development

Successfully merging this pull request may close these issues.
2 participants
@tgrandje @hadrilec