Add support for specifying timeout in catalogs #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnksv
force-pushed
the
add-support-for-catalog-timeout
branch
from
6ecca40
to
4408435
Compare
Since some chart may use more than the standard 5 min timeout that helm is configured with to install. Use string as type since there was some issues with using java.time.Duration and parsing with jackson.
johnksv
force-pushed
the
add-support-for-catalog-timeout
branch
from
4408435
to
a601126
Compare
|
|
LGTM, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P.t. every chart uses the default 5 min helm timeout. We have however encountered that some chart may use more than these 5 minutes to get installed. This can be due to a combination of scale up + pulling images + mounting buckets. Therefore we need a way to configure timeout.
This PR propose specifying the timeout during install on the catalog:
Originally I wanted to implement this as a
java.time.Duration, but due to some issues with jackson I ended up usingString