Implement support for specifying container when getting logs #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a pod have more than one container the current call will fail. This commit fix that issue, while perserving backward compability in the api by making the container id parameter optional. The get logs call will behave as before if container id is null or empty
|
|
Closing as many changes are to come due to better pod detection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a pod have more than one container the current call will fail. This commit fix that issue, while preserving backward compatibility in the api by making the container id parameter optional.
The get logs call will behave as before if container id is null or empty.
This change may not make sense if there is no plan to implement support for this in the frontend (other changes may be required by api for this, such as returning which containers the pod contain).
If that is the case, feel free to close this PR