Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add certManager in region configuration #410

Merged
merged 2 commits into from
Mar 29, 2024
Merged

add certManager in region configuration #410

merged 2 commits into from
Mar 29, 2024

Conversation

ihiverlet
Copy link
Contributor

close #380

@ihiverlet ihiverlet requested a review from olevitt March 26, 2024 12:42
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 26, 2024
olevitt
olevitt requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@olevitt olevitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think certManager should be a children of services.expose

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ihiverlet ihiverlet requested a review from olevitt March 27, 2024 08:33
olevitt
olevitt approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@olevitt olevitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks 👍
We may want to add support for issuer in addition to clusterIssuer but that may come later

@olevitt olevitt added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Mar 29, 2024
@olevitt olevitt merged commit 4183106 into main Mar 29, 2024
8 checks passed
@olevitt olevitt deleted the add-certManager-in-region-configuration branch March 29, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olevitt olevitt olevitt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify Region configuration for certManager
2 participants
@ihiverlet @olevitt