Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] Update packaging #89

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[MAINT] Update packaging #89

wants to merge 5 commits into from

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Sep 18, 2023 •
edited
Loading

Before reviewing this Pull Request, please review Pull Request [#](add a link to the Pull Request here).

Changes proposed in this Pull Request:

  • move all packaging configuration into a pyproject.toml
    • remove setup.py and setup.cfg
  • use hatchling for packaging instead of setuptools
  • move flake8 config in its dedicated file
  • move codespell config into pyproject.toml

Checklist:

  • Descriptive title
  • Targets the main branch
  • Changes are functional
  • My code is explicit and comments were added to it
  • Code conforms with PEP8
  • Tests were added for the changes and they complete successfully
  • Existing tests were updated (if needed) and they complete successfully
  • Documentation was updated

Remi-Gau
Remi-Gau commented Sep 18, 2023
View reviewed changes
environment.yml Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: check that this is still installable

Remi-Gau
Remi-Gau commented Sep 18, 2023
View reviewed changes
pytest.ini Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to pryproject.toml

Remi-Gau
Remi-Gau commented Sep 18, 2023
View reviewed changes
setup.py
requires = [
'importlib_resources>=5.10.2,<5.11',
'tomli>=2.0.1,<2.1',
'networkx>=2.0,<3.0', # a workaround to nipype's bug (issue 3530)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this requirement was removed and switched to bumping up the nipype requirement instead as this is now fixed

@Remi-Gau Remi-Gau marked this pull request as ready for review September 18, 2023 23:19
@Remi-Gau Remi-Gau requested a review from a team as a code owner September 18, 2023 23:19
@bclenet bclenet self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bclenet bclenet bclenet left review comments

Assignees

@bclenet bclenet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python dependencies simplification
2 participants
@Remi-Gau @bclenet