Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3C6G] Reproduction #106

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

elodiegermani
Copy link
Collaborator

This Pull Request is related to issue #105.

Changes proposed in this Pull Request:

  • Implementation of pre-processing pipeline for team 3C6G
  • Implementation of tests for pre-processing pipeline

Checklist:

  • Descriptive title
  • Targets the main branch
  • Changes are functional
  • My code is explicit and comments were added to it
  • Code conforms with PEP8
  • Tests were added for the changes and they complete successfully
  • Existing tests were updated (if needed) and they complete successfully
  • Documentation was updated

@bclenet
Copy link
Collaborator

bclenet commented Oct 17, 2023

Hi @elodiegermani,

You can replace the line :

    '3C6G': None,

by

    '3C6G': 'PipelineTeam3C6G',

In the narps_open/pipelines/__init__.py file. That should allow your pipeline to be tested properly by the CI.

You can merge the latest revision of the main branch to yours as well. This will prevent from executing outdated unit tests.

Once done, I'll check the pipeline_tests executions to see if there are errors left due to the narps_open package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants