-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a markmap mind map page for scaling InnerSource #901
base: master
Are you sure you want to change the base?
Conversation
feat: add markmap shortcode feat: add markmap friendly markmap content fix: skip yourmax processing if no items defined
Hi @jeffabailey , I tested the PR locally and found two issues:
I found a way to fix 1 and I'll send a PR on top of this PR with a fix. |
This commit fixes an issue on the `/learn` page introduced with the mindmap for scaling. Acording to my tests: 1. If a folder does not have a `_index.md` file, every file under the folder will generate a section under the `/learn` page. in This way, both files, `mindmap.md` and `markmap_content.md` were generating content. To fix this, I renamed `mindmap.md` to `_index.md`. 2. When a file does not mave a `description` property in the frontmatter block, it will use the content of the file as description. To fix this I added a `description` property to `mindmap.md` (now renamed to `_index.md`. Related issues - #902 (comment)
@jeffabailey , here is the proposed fix: #902 |
content/en/learn/scaling/mindmap.md
Outdated
weight: 1 | ||
--- | ||
|
||
{{< markmap path="markmap_content.md" >}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffabailey all the other files on the repo use a -
as separator.
I suggest renaming markmap_content.md
to markmap-content.md
for consistency.
Also, it would be nice if we could make the links open in a new tab, but I think that would require some implementation.
by adding a transformer plugin with something like this, we may be able to do it:
I'll need to test this later. |
…w-scaling-content fix: Scaling content on Learn page
Unless we compact the mindmap, I'm afraid that's an avoidable quirk. However, assuming that all operating systems and browsers allow you to hold ctrl to pan the mindmap in any direction, we could put a quick instruction above the mindmap. |
I was thinking about that too, some instructions on top would be nice. I don't think we need to hold the merge for that though, that could be an increment with another PR, unless you want to include it already, up to you @jeffabailey . One minor ask, can you please link to https://docs.google.com/document/d/12PFkoiaukmrMbnTPYKERzViKCULfClutXN4ydVPv3H0/edit on the description of the PR? Just for additional traceability on the origin of the mindmap. |
Hello @InnerSourceCommons/website-maintainers do you have any concerns with merging this PR? If no, please approve. :) |
An output of an @InnerSourceCommons/ispo-working-group meeting: https://docs.google.com/document/d/12PFkoiaukmrMbnTPYKERzViKCULfClutXN4ydVPv3H0/edit
feat: add markmap partial
feat: add markmap shortcode
feat: add markmap friendly markmap content
fix: skip yourmax processing if no items defined