Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazilian Portuguese Language Support 🇧🇷 #553

Merged
merged 46 commits into from
Aug 29, 2023
Merged

Brazilian Portuguese Language Support 🇧🇷 #553

merged 46 commits into from
Aug 29, 2023

Conversation

yuhattor
Copy link
Member

@yuhattor yuhattor commented Jun 1, 2023

Brazilian Portuguese Language Support

The InnerSource Commons (ISC) website is available in multiple languages. We appreciate your help in translating the site to make it accessible to Brazilian Portuguese speakers.

please keep in mind followings

Please note the following guidelines:

  • Before beginning your translation, please read the i18n.md file for information on tools and processes.
  • Do not edit or create any files under content/en/learn/learning-path/. These files are sourced from another repository and are not stored in the innersourcecommons.org repository. If you want to add or edit a language, please do so in the learning-path repository.
  • Please do not include any untranslated files in your pull request (PR). Missing files will be automatically added from content/en at build time.

Files to be translated

The following is a list of files that should be translated first. It is a good idea to translate from here, but you are not required to follow it.

Setting files

  • i18n/pt-br.yaml
  • config/_default/menus.pt-br.yaml

Content files

  • content/pt-br/about/announcements/_index.md
  • content/pt-br/about/_index.md
  • content/pt-br/about/sponsors.md
  • content/pt-br/about/members.md
  • content/pt-br/about/board/_index.md
  • content/pt-br/about/codeofconduct.md
  • content/pt-br/about/contact.md
  • content/pt-br/community/_index.md
  • content/pt-br/community/services.md
  • content/pt-br/events/_index.md
  • content/pt-br/_index.md
  • content/pt-br/learn/_index.md
  • content/pt-br/learn/books/managing-innersource-projects.md
  • content/pt-br/learn/books/innersource-patterns.md
  • content/pt-br/learn/books/_index.md
  • content/pt-br/learn/books/adopting-innersource-principles-and-case-studies.md
  • content/pt-br/learn/books/understanding-the-innersource-checklist.md
  • content/pt-br/learn/books/getting-started-with-innersource.md
  • content/pt-br/learn/patterns.md
  • content/pt-br/learn/research/state-of-innersource-survey-2021.md
  • content/pt-br/learn/research/state-of-innersource-survey-2016.md
  • content/pt-br/learn/research/_index.md
  • content/pt-br/learn/research/state-of-innersource-survey-2020.md
  • content/pt-br/redirects/patterns.md
  • content/pt-br/stories/_index.md
  • content/pt-br/stories/microsoft.md

The conditions for merging are as follows

  • Website-mainterners Approval
  • Native check
    While machine translation can be useful for large volumes of text and can serve as a starting point for translation, it can also produce unprofessional results. In addition, since machine translation can be used by anyone with a browser extension, this translation project requires a more professional level
  • At least 50% of the files in the "Files to be translated" section should be translated

@yuhattor yuhattor requested a review from a team as a code owner June 1, 2023 16:18
Copy link
Contributor

@fer-correa fer-correa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the suggestions I've made so far.

I will resume the review asap

content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
@yuhattor
Copy link
Member Author

Thank you for the review and revision!
Please let me know when you need my support on this or when the PR is ready to merge!

Copy link
Member Author

@yuhattor yuhattor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As sugestões agora são exibidas!

content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/board/_index.md Outdated Show resolved Hide resolved
content/pt-br/about/board/_index.md Outdated Show resolved Hide resolved
@yuhattor
Copy link
Member Author

@fer-correa

Here's a staging, please check that with your friends!
I think there is some instability...
https://innersourcecommons.jp/pt-br/

@yuhattor
Copy link
Member Author

@fer-correa
What is your overall impression?
Do you think it's ready to release? We need some other native speakers to check it out if you don't mind 👀

@fer-correa
Copy link
Contributor

Great idea @yuhattor

The more reviewers we have the better it will be.
Otherwise, we will certainly get feedback from the community after publication, as I believe this will generate more engagement.

@galmeida125
Copy link

Hi everyone!

I did a brief review and the translation looks very good to me.

(native brazilian speaking here :))

@yuhattor
Copy link
Member Author

Thank you!!

Here's the current status

@yuhattor
Copy link
Member Author

yuhattor commented Jul 11, 2023

Hi @rrrutledge,

I think it's ready to merge after some confirmations about i18n settings.
Also I think we can finish the initial native check process here. What do you think? If you think it's mergeable in terms of the native check, please approve it!

Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yuhattor ❗ Getting this in sounds great to me as it will allow us to finish our Brazilian Portuguese translation of the Learning Path.

@yuhattor
Copy link
Member Author

Fantastic! I'll start getting ready for the deployment 🚀

@yuhattor
Copy link
Member Author

yuhattor commented Aug 3, 2023

NOW IT'S TIME TO MERGE 🎉 🎉 🎉

Here's the staging site: https://isc-i18n.github.io/pt-br/
The staging site has the latest state of this branch, forked and merged with the current latest master. So this staging site will be the state after merging this PR.

Please review and confirm that it works properly
@rrrutledge: Could you please check that the website works correctlly, just in case
@fer-correa: Please double check that the language/contents are fine:)

@InnerSourceCommons/website-maintainers
I think I will be asking for an approve for the merge soon.
I will mention this to notify the current status.
jfyi: @voborgus and @andrea-kyurchiev

@yuhattor yuhattor changed the title [WIP] Brazilian Portuguese Language Support 🇧🇷 Brazilian Portuguese Language Support 🇧🇷 Aug 3, 2023
@rrrutledge rrrutledge requested review from marshmallowrobot and removed request for marshmallowrobot August 3, 2023 12:16
@rrrutledge
Copy link
Contributor

@marshmallowrobot is looking at how the Brazilian-translated learning path articles will show up on the website and can try those out with this version of the site to see if it works.

@yuhattor
Copy link
Member Author

yuhattor commented Aug 4, 2023

Thank you! It looks like pt-br has not been merged into learning-path main/master yet.
I hope to be able to merge the following after merging this, but I wonder if Learning-Path Brazilian-Portuguese is ready to merge?? https://github.com/InnerSourceCommons/InnerSourceLearningPath/pulls

@fer-correa
Copy link
Contributor

We are working on these PRs as possible... I believe we are very close to crossing the finish line 😄

@yuhattor
Copy link
Member Author

yuhattor commented Aug 4, 2023

@fer-correa Thanks!!

@rrrutledge
Copy link
Contributor

There are a few Learning Path PRs that are already in. You can go through the steps of updating the website with new articles to see if those finished articles work with these changes.

@yuhattor
Copy link
Member Author

yuhattor commented Aug 29, 2023

@InnerSourceCommons/website-maintainers
@voborgus
Please merge this, I confirmed from technical perspective.
https://isc-i18n.github.io/pt-br/

Copy link
Collaborator

@voborgus voborgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm everything works as expected locally, going to merge and deploy this.

@fer-correa @galmeida125 @yuhattor @rrrutledge you are rockstars! 🔥🔥🔥

@voborgus voborgus merged commit 10468be into master Aug 29, 2023
8 checks passed
@voborgus voborgus deleted the i18n-pt-br branch August 29, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants