(feat) Added documentation about order types #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source/includes/_overview.md
Outdated
| ## Order types | ||
|
|
||
| - BUY (1): A standard buy order to purchase an asset at either the current market price or a set limit price. |
There was a problem hiding this comment.
Even for market orders, users MUST set the worst price so I think we should make that clear, the price for both limit and market orders is 'set'.
There was a problem hiding this comment.
I have applied the change in the latest commit
source/includes/_overview.md
Outdated
| - BUY_PO (7): Post-Only Buy. This order type ensures that the order will only be added to the order book and not match with a pre-existing order. It guarantees that you will be the market "maker" and not the "taker". | ||
| - SELL_PO (8): Post-Only Sell. Similar to BUY_PO, this ensures that your sell order will only add liquidity to the order book and not match with a pre-existing order. | ||
| - BUY_ATOMIC (9): An atomic buy order is a market order that gets executed instantly, bypassing the Frequent Batch Auctions (FBA). It's intended for smart contracts that need to execute a trade instantly. A higher fee is paid defined in the global exchange parameters. |
There was a problem hiding this comment.
Maybe here we can mention the fee for atomic orders is currently "double" the normal trading fee.
There was a problem hiding this comment.
I have added the clarification in the last commit
|
@arcayne please check the comments from Achilleas. We might want to do the same clarifications in the injective-core documentation |
achilleas-kal
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overviewsection detailing all order types