feat: add stream docs #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarmoa
requested changes
Aug 7, 2023
| func main() { | ||
| tlsConfig := tls.Config{InsecureSkipVerify: true} | ||
| creds := credentials.NewTLS(&tlsConfig) | ||
| cc, err := grpc.Dial("staging.stream.injective.network:443", grpc.WithTransportCredentials(creds)) |
There was a problem hiding this comment.
Is this the correct way to specify the URL? I think we should be using a network instance (with common.LoadNetwork) as in all other Go examples
There was a problem hiding this comment.
This is the idiomatic go gRPC way to connect to a grpc server. In others example there is the need to use more sofisticated connection solutions in order to interact with the chain. Streamer is a simple grpc readonly server that does not requires to use such complexity. For golang developers this is very easy to read.
There was a problem hiding this comment.
But I got your point. When we will deploy prod stream dns I will change this part, ty
aarmoa
approved these changes
Aug 9, 2023
|
Closing this PR because its changes have been included in #139 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add docs related to new chain stream api