Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El pull request en cuestión presenta test de los submódulos Organization review, Doner Review y Donation Request. Aumentando el curbimiento que actualmente posee el módulo common/models desde 21.33% hasta 63.46%. El cubrimiento particular de cada uno de los submódulos pasa de ser
- Organization Review: 8% -> 72%
- Donation Request: 22% -> 88%
- Donner Review: 16% -> 55%
El procedimiento para ejecutar los test y poder comprobar cubrimiento es el siguiente:
1) Modificar la linea test de el archivo package.json para que quede de la siguiente manera:
"test": "nyc mocha ./test/*.test.js -S --exit"
2) Agregar la siguiente linea al apartado scripts del archivo package.json
"nycreport": "nyc report --reporter=html"
3) Ejecutar el comando "npm test" para ejecutar los test.
4) Ejecutar el comando "npm run nycreport" para generar un html con los cubrimiento de los test.
Aclaraciones:
1) Previamente a ejecutar el procedimiento para generar cubrimento se debe instalar la herramienta necesaria (nyc report):
npm install nyc
2) El html con los cubrimientos se genera dentro del directorio coverage en un archivo llamado index.html.
Autores:
Gabriel Cancellieri
Lucas Pérez
Kevin Isaia
Para:
@webocs @abuccella @aderenzis @mgarriga