Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update report json schema for git branch information #914

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Oct 24, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • after v0.34.0, git_branch information in a run report could be null when compared with git references other than branches.

Which issue(s) this PR fixes:
sc-32458

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@wcchang1115 wcchang1115 changed the title [Bug] Make git branch information nullable [Bug] Update report json schema for git branch information Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #914 (0f50269) into main (c35b2b7) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #914   +/-   ##
=======================================
  Coverage   48.00%   48.01%           
=======================================
  Files          78       78           
  Lines       10751    10751           
=======================================
+ Hits         5161     5162    +1     
+ Misses       5590     5589    -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcchang1115 wcchang1115 marked this pull request as ready for review October 25, 2023 02:15
@qrtt1 qrtt1 merged commit 294b792 into main Oct 25, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants