Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] sc-32292 PipeRider CLI support share to temporary quick look #889

Merged

Conversation

kentwelcome
Copy link
Member

@kentwelcome kentwelcome commented Sep 14, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Feature

What this PR does / why we need it:

  • Enable Quick Look upload by feature flag --enable-quick-look-share or ENVVAR PIPERIDER_ENABLE_QUICK_LOOK_SHARE=true
  • Use option --share without login PipeRider Cloud, upload the report to PipeRider Temporary Quick Look
  • Support commands:
    • run
    • compare-reports
    • compare
Is Login --upload --share --enable-quick-look-share Upload Behavior
❌ or ✅ Do nothing
❌ or ✅ Upload & Share to project
❌ or ✅ Upload & Share to project
❌ or ✅ Upload to project
❌ or ✅ Do nothing
❌ or ✅ Do nothing & show warning message
Do nothing & show warning message
❌ or ✅ Do nothing & show warning message
Upload to Quick Look

Which issue(s) this PR fixes:
sc-32292

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #889 (7827e71) into main (48348e4) will increase coverage by 0.14%.
The diff coverage is 43.01%.

@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   48.16%   48.30%   +0.14%     
==========================================
  Files          76       76              
  Lines       10572    10609      +37     
==========================================
+ Hits         5092     5125      +33     
- Misses       5480     5484       +4     
Files Changed Coverage Δ
piperider_cli/compare_report.py 30.31% <0.00%> (-0.55%) ⬇️
piperider_cli/cloud_connector.py 14.68% <18.75%> (-0.29%) ⬇️
piperider_cli/cloud/__init__.py 25.78% <21.73%> (+0.05%) ⬆️
piperider_cli/cli_utils/compare_with_recipe.py 23.33% <33.33%> (+2.28%) ⬆️
piperider_cli/cli.py 67.18% <83.33%> (+1.86%) ⬆️
piperider_cli/cli_utils/__init__.py 95.55% <100.00%> (+4.25%) ⬆️
piperider_cli/cli_utils/run_cmd.py 92.39% <100.00%> (+8.55%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kentwelcome kentwelcome force-pushed the feature/sc-32292/cli-piperider-cli-can-upload-the-report-to branch from 722fd30 to 839071f Compare September 14, 2023 14:04
@kentwelcome kentwelcome force-pushed the feature/sc-32292/cli-piperider-cli-can-upload-the-report-to branch from 839071f to 7827e71 Compare September 25, 2023 07:17
@kentwelcome kentwelcome marked this pull request as ready for review September 25, 2023 07:30
@kentwelcome kentwelcome requested a review from qrtt1 September 25, 2023 07:32
@kentwelcome kentwelcome merged commit b5da041 into main Sep 25, 2023
33 checks passed
kentwelcome added a commit that referenced this pull request Oct 24, 2023
Add some comments to explain the feature flag of `--enable-quick-look-share` implemented by #889 

Signed-off-by: Kent Huang <[email protected]>
kentwelcome added a commit that referenced this pull request Oct 24, 2023
Add some comments to explain the feature flag of `--enable-quick-look-share` implemented by #889 

Signed-off-by: Kent Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants