-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Support piperider compare between git refs #888
[Feature] Support piperider compare between git refs #888
Conversation
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
==========================================
- Coverage 48.15% 48.05% -0.10%
==========================================
Files 75 75
Lines 10390 10461 +71
==========================================
+ Hits 5003 5027 +24
- Misses 5387 5434 +47
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comment in the review, there are some additional notes
-
When we use HEAD, could we mark the HEAD as the current branch in the report?
-
The error message is not clear
$ piperider compare main main HEAD Error: Commit format is not supported
we can say we only support one or no reference
-
Clearer help
$ piperider compare --help Usage: piperider compare [OPTIONS] [REFS]... $ git diff --help NAME git-diff - Show changes between commits, commit and working tree, etc SYNOPSIS git diff [<options>] [<commit>] [--] [<path>...] git diff [<options>] --cached [--merge-base] [<commit>] [--] [<path>...] git diff [<options>] [--merge-base] <commit> [<commit>...] <commit> [--] [<path>...] git diff [<options>] <commit>...<commit> [--] [<path>...]
Signed-off-by: Wei-Chun, Chang <[email protected]>
Signed-off-by: Wei-Chun, Chang <[email protected]>
c4406a8
to
1d58ce5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR checklist
What type of PR is this?
feature
What this PR does / why we need it:
piperider compare <git-ref>...<git_ref>
Which issue(s) this PR fixes:
sc-31643
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE