Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Fix unit-test failed by dbt-core 1.6.2 #884

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

kentwelcome
Copy link
Member

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
Chore

What this PR does / why we need it:

  • Fix unit test failed issues by dbt-core v1.6.2

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #884 (509ca4d) into main (52a79ad) will increase coverage by 0.01%.
Report is 7 commits behind head on main.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
+ Coverage   46.40%   46.41%   +0.01%     
==========================================
  Files          75       75              
  Lines       10356    10358       +2     
==========================================
+ Hits         4806     4808       +2     
  Misses       5550     5550              
Files Changed Coverage Δ
piperider_cli/__init__.py 52.17% <66.66%> (ø)
piperider_cli/dbt/list_task.py 65.65% <100.00%> (+0.19%) ⬆️
piperider_cli/event/__init__.py 78.12% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popcornylu popcornylu merged commit 0a4839a into main Sep 12, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants