Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add restriction to dbt 1.6 metric support #875

Merged

Conversation

wcchang1115
Copy link
Contributor

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
feature

What this PR does / why we need it:

  • We have supported basic dbt 1.6 metric query but have some limitations.

Which issue(s) this PR fixes:
sc-32064

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #875 (a6b1e35) into main (fb1bbdc) will increase coverage by 0.01%.
Report is 8 commits behind head on main.
The diff coverage is 60.97%.

@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   46.39%   46.40%   +0.01%     
==========================================
  Files          75       75              
  Lines       10306    10337      +31     
==========================================
+ Hits         4781     4797      +16     
- Misses       5525     5540      +15     
Files Changed Coverage Δ
piperider_cli/metrics_engine/metrics.py 24.24% <40.00%> (+0.53%) ⬆️
piperider_cli/dbtutil.py 67.10% <63.88%> (-0.82%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcchang1115 wcchang1115 marked this pull request as ready for review September 5, 2023 03:35
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this implementation, we don't know what exact the metrics to be skipped.

image

Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popcornylu popcornylu merged commit 3fb8ee4 into main Sep 5, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants