Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] add warning at impact summary #868

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Aug 31, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

bugfix

What this PR does / why we need it:

show impact summary broken messages

Which issue(s) this PR fixes:

sc-32180

Special notes for your reviewer:

This PR only updates the UI, it must be working with the API server.

image

Signed-off-by: Ching Yi, Chan <[email protected]>
@qrtt1 qrtt1 requested a review from wcchang1115 August 31, 2023 03:19
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #868 (b89765b) into main (f128375) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #868   +/-   ##
=======================================
  Coverage   47.88%   47.88%           
=======================================
  Files          71       71           
  Lines       10003    10003           
=======================================
  Hits         4790     4790           
  Misses       5213     5213           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Ching Yi, Chan <[email protected]>
Copy link
Contributor

@wcchang1115 wcchang1115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qrtt1 qrtt1 merged commit 8b3226c into main Aug 31, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants